## Purpose:
- Upgrade composer repository

## Link to docs:
- https://www.drupal.org/node/2822344

CommentFileSizeAuthor
#13 2849014-remove-composer-json.patch794 bytesDave Reid
#9 packages-update-2849014-9.patch438 bytesccjjmartin
#5 packages-update-2849014-4.patch315 bytesccjjmartin
#2 packages-update-2849014-2.patch577 bytesccjjmartin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ccjjmartin created an issue. See original summary.

ccjjmartin’s picture

ccjjmartin CreditAttribution: ccjjmartin as a volunteer commented
FileSize
packages-update-2849014-2.patch577 bytes
ccjjmartin’s picture

ccjjmartin CreditAttribution: ccjjmartin as a volunteer commented
Status: Active » Needs review
marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano as a volunteer commented
Status: Needs review » Needs work
Issue tags: +D8Media

Can you please double check your patch? It is not changing anything

ccjjmartin’s picture

ccjjmartin CreditAttribution: ccjjmartin as a volunteer commented
FileSize
packages-update-2849014-4.patch315 bytes
ccjjmartin’s picture

ccjjmartin CreditAttribution: ccjjmartin as a volunteer commented
Status: Needs work » Needs review

Somehow picked up the latest commit on 1.x instead of my patch. Looks right now.

slasher13’s picture

slasher13
Primary language German
CreditAttribution: slasher13 as a volunteer and at Wolters Kluwer commented
Status: Needs review » Reviewed & tested by the community
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Needs work

There is actually no reason for that to be in there at all.

Just remove the whole definition, it is not used anyway unless you use composer_manager or so that supports merging those things.

ccjjmartin’s picture

ccjjmartin CreditAttribution: ccjjmartin as a volunteer commented
FileSize
packages-update-2849014-9.patch438 bytes

Following Berdir's recommendation of removing the definition appears to be working for me.

ccjjmartin’s picture

ccjjmartin CreditAttribution: ccjjmartin as a volunteer commented
Status: Needs work » Needs review
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

It should, yes :)

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented

I don't actually see a reason why we even need to keep composer.json here now that it's provided automatically for us by using the Drupal.org packagist repo?

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Reviewed & tested by the community » Needs review
FileSize
2849014-remove-composer-json.patch794 bytes

Dave Reid credited kerby70.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented

Status: Needs review » Needs work

The last submitted patch, 13: 2849014-remove-composer-json.patch, failed testing.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented

I've tested in another module that the testbot cannot test removing an existing composer.json file, so this is good to commit.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented

  • Dave Reid committed dedbf05 on 8.x-1.x 
    Issue #2849014 by ccjjmartin, Dave Reid, Berdir, kerby70: Removed the...
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Needs work » Fixed

Committed to 8.x-1.x. Marking as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.