I think a follow-up for test coverage covering all of schema.inc is fine - we do want to remove the deprecated calls in tests, but we also want to add explicit test coverage for deprecated code too: https://www.drupal.org/core/deprecation
Hi All ,
I am getting this exception when using new syntax in my module 'PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'unsigned NOT NULL COMMENT ' AMOUNT', rate unsigned NOT NULL COMMENT 'R' at line 3: CREATE TABLE {sampletest} ( id INT unsigned NOT NULL COMMENT 'My unique identifier', amount unsigned NOT NULL COMMENT 'AMOUNT', rate unsigned NOT NULL COMMENT ' RATE', time unsigned NOT NULL COMMENT ' TIME', PRIMARY KEY (id) ) ENGINE = InnoDB DEFAULT CHARACTER SET utf8 COMMENT ' table'; Array ( ) in db_create_table()'
Comments
Comment #2
vidhatanand CreditAttribution: vidhatanand at OpenSense Labs commentedComment #3
JayKandari3 instances of "db_create_table()" found in following Files:
#2 Looks Good.
Thanks!
Comment #4
cilefen CreditAttribution: cilefen commentedYou cannot change these files because they are executed in older Drupal versions.
Comment #5
xjmComment #6
juanjesustrigo CreditAttribution: juanjesustrigo at La Drupalera by Emergya commentedI'll work on this
Comment #7
juanjesustrigo CreditAttribution: juanjesustrigo at La Drupalera by Emergya commentedI have made the changes explained in #4
Comment #8
daffie CreditAttribution: daffie commentedLooks good
Comment #9
nesta_ CreditAttribution: nesta_ at La Drupalera by Emergya commentedadd Tag
Comment #10
juanjesustrigo CreditAttribution: juanjesustrigo at La Drupalera by Emergya commentedComment #12
jeetendrakumar CreditAttribution: jeetendrakumar as a volunteer and at HyTechPro.com commentedComment #13
daffie CreditAttribution: daffie commented@jeetendrakumar: The drupal core committers do not want the same changes made to test classes. See #2848479: Replace all calls to db_drop_table, which is deprecated..
Back to RTBC for the patch from comment #7.
Comment #14
cilefen CreditAttribution: cilefen commentedI cannot commit #7 because there is a coding standard violation.
Comment #15
jeetendrakumar CreditAttribution: jeetendrakumar as a volunteer and at HyTechPro.com commentedComment #16
jeetendrakumar CreditAttribution: jeetendrakumar as a volunteer and at HyTechPro.com commentedAs per comment #14, Solved coding standard violation.
Comment #17
jeetendrakumar CreditAttribution: jeetendrakumar as a volunteer and at HyTechPro.com commentedComment #18
ajmantis CreditAttribution: ajmantis at La Drupalera by Emergya commentedLooks good
Comment #20
juanjesustrigo CreditAttribution: juanjesustrigo at La Drupalera by Emergya commentedComment #21
juanjesustrigo CreditAttribution: juanjesustrigo at La Drupalera by Emergya commentedI Put the issue in RTBC after retest pass.
Comment #22
catchI think a follow-up for test coverage covering all of schema.inc is fine - we do want to remove the deprecated calls in tests, but we also want to add explicit test coverage for deprecated code too: https://www.drupal.org/core/deprecation
Committed/pushed to 8.4.x, thanks!
Comment #25
Anonymous (not verified) CreditAttribution: Anonymous commentedHi All ,
I am getting this exception when using new syntax in my module 'PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'unsigned NOT NULL COMMENT ' AMOUNT', rate unsigned NOT NULL COMMENT 'R' at line 3: CREATE TABLE {sampletest} ( id INT unsigned NOT NULL COMMENT 'My unique identifier', amount unsigned NOT NULL COMMENT 'AMOUNT', rate unsigned NOT NULL COMMENT ' RATE', time unsigned NOT NULL COMMENT ' TIME', PRIMARY KEY (id) ) ENGINE = InnoDB DEFAULT CHARACTER SET utf8 COMMENT ' table'; Array ( ) in db_create_table()'
Comment #26
cilefen CreditAttribution: cilefen commentedThis issue affects an unreleased version of Drupal. Open a new support issue and post your code.