Problem/Motivation

A message with a single link (or no link at all) is correctly processed and sent. However, if a message contains multiple links, it strips out all the links in the message. Only the text outside the <a> tags is sent to Slack.

This is because of incorrect placement of the replacement loop for strings in processMessage.

Proposed resolution

I think we can generally improve the overall handling of links as there might be other issues in the future (e.g., we can't send text like link-1 along with a link in the message). For now, I am thinking we fix the bug here in short-term as it completely breaks the module.

CommentFileSizeAuthor
#2 multiple_links_corrupts-2848176-2.patch881 byteshussainweb

Comments

hussainweb created an issue. See original summary.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new multiple_links_corrupts-2848176-2.patch881 bytes

This patch fixes the problem for me.

adci_contributor’s picture

adci_contributor commented

Hi, hussainweb!

Thanks for your patch. We added it to the dev-branch.
Best regards

adci_contributor credited irina_gibasheva.

adci_contributor’s picture

adci_contributor commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.