Problem/Motivation

Currently the tab items contain the class horizontal-tab-button+i however it is not easy to retrieve the numeric key (i) of the currently selected tab. Therefor it is useful we we have an attribute for this - horizontal-tab-button="i".

Proposed resolution

Add the attribute horizontal-tab-button to each tab item.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 2848008-8.patch502 byteskfritsche
#7 2848008-7.patch497 bytesgraceman9
#2 2848008-2.patch499 byteshchonov
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hchonov created an issue. See original summary.

hchonov’s picture

hchonov
Primary language Bulgarian
Location 🇪🇺🇩🇪🇧🇬
CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented
FileSize
2848008-2.patch499 bytes
kay_v’s picture

kay_v CreditAttribution: kay_v as a volunteer commented
Version: 8.x-1.x-dev » 8.x-3.x-dev

this patch applies cleanly and resolves the stated issue when applied to field_group-8.x-3.x-dev

I'm switching the issue version to the above since the current core version (Drupal 8.4) requires it per the module project page:

For Drupal 8.3 and higher, use the fieldgroup 8.3 branch. When you still use a drupal version lower then 8.3, use the fieldgroup 8.1 branch

kay_v’s picture

kay_v CreditAttribution: kay_v as a volunteer commented
Status: Needs review » Needs work
kay_v’s picture

kay_v CreditAttribution: kay_v as a volunteer commented
Status: Needs work » Needs review
geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin commented
Status: Needs review » Needs work

This sounds useful. Please add a data- prefix to the attribute to get valid html.
https://stackoverflow.com/a/31810008/606859

graceman9’s picture

graceman9 CreditAttribution: graceman9 at Internetdevels, Drupal Ukraine Community for Internetdevels commented
Status: Needs work » Needs review
FileSize
2848008-7.patch497 bytes

Does anyone still need this?

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
CreditAttribution: kfritsche at bio.logis Genetic Information Management GmbH commented
FileSize
2848008-8.patch502 bytes

We still use this, but with a slight different version.

We use "attr('data-horizontalTabButton', i)" instead of data, because this is also used in our testing (behat + browsertest) and jqueries data doesn't serialize this back as an attribute to the DOM.

nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop as a volunteer and at iO commented
Status: Needs review » Fixed

Thx for the patch. I committed it to dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.