Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.When adding the "Stemmer" processor, we forgot to also add it to the processor integration test. We should do that now.
See #2823985: Add integration test for the "Role filter" processor for pointers.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | add_stemmer_to-2847810-5.patch | 1.31 KB | JayKandari |
Comments
Comment #2
JayKandariComment #3
JayKandariAdded test for "Stemmer" processor in ProcessorIntegrationTest.php.
Kindly Review. Thanks!
Comment #5
JayKandariCorrected #3. Now review !! :)
Comment #6
JayKandariComment #8
JayKandariStrange!! all search_api tests passed locally!! am I missing here something?
Comment #9
borisson_Yeah, this is because of a new 8.3 patch; I noticed this yesterday and opened #2850930: Fix testfailure because of missing originalDirectory
Comment #10
JayKandari@borisson_ : I see. Thanks for clarifying. Is this postponed till #2850930 gets resolved?
Comment #11
borisson_Not officially, no. But since @drunken monkey prefers not tot commit things when the tests are not green that one needs to happen first. No need to go and set all open d8 issues on postponed though :-)
Comment #12
JayKandariPatch #5 was causing error due to (#2851533: Adapt to latest Core changes). Since it is resolved now, re-ran the tests. It passed.
Changing status. Kindly Review. Thanks !
Comment #14
drunken monkeyLooks great, thanks a lot! Everything done right, no complaints.
I just moved the
checkStemmerIntegration()method so the method definitions are in the same order as the method calls – that just makes it a bit easier to find things, I think.Otherwise, as said, no complaints, so: committed.
Thanks again!