Returning to normal mode is tedious and confusing [#2847674]

Problem/Motivation

Going into click-edit mode requires just one click, but returning to the normal mode with the Manage or Shortcut menu visible requires three clicks - on different corners of the screen window, and with unclear labels.

A user can enter the quick edit mode by clicking on the "Quick edit" contextual link on a block - without using or even being aware of the "Edit" link at the top left corner. They then save their changes at the bottom of settings tray at the right hand side. To leave the "Quick edit" mode they then need to click on the "Editing" link at the top left corner, and then they need to enable the manage menu again.

The step to click "editing" to get out of the quick edit mode seems to be unnecessary because the user did not contumaciously enter that mode. Even more so because when you click "Quick edit" to edit content, then you don't get into a different mode.
Also the label "Editing" is confusing because "editing" is not what the user wants to do. In general links in Drupal describe what the user will do when they click on that link or something that they will go to. I can't think of any other button that describes what the user is currently doing. Clearer would be "Edit/Stop editing" or "Quick-edit mode/Leave edit mode".

However, if a user clicks on a link in the systems tray (for example the Advanced options to edit more block configuration, or to edit a menu item) then saving that returns them to the normal mode.

If a user edits a menu link then they are either returned to the site (if they edit custom link) or brought to the configuration page of the menu (if they edit a menu item provide by code, such as the 'Home').

Proposed resolution

(1) If a user uses the quick edit mode by just clicking on a contextual link, then saving the changes, or closing the settings tray should return them to the normal mode.
(2) If one of the menus (Manage, Shortcuts, User) are enabled when a users clicks on a quick-edit link, then they need to be enabled again when the user leaves that mode.
(3) The "Editing" label should be replaced with a label that describes what will happen when the link is clicked to be consistent with other labels.

Remaining tasks

User interface changes

Comments

Comment #1

28 January 2017 at 15:54

ifrik created an issue. See original summary.

Comment #2

ifrik

she/her

CreditAttribution: ifrik commented 28 January 2017 at 16:01

Issue summary:

View changes

Comment #3

tkoleary CreditAttribution: tkoleary at Acquia commented 30 January 2017 at 17:11

Very good points.

Rather than add the overhead of maintaining a solution that attempts to guess at the users intent, why don't we just offer two submits?

Save and edit
Save and exit

This adds less code and also permits the user more explicit control.

Comment #4

ifrik

she/her

CreditAttribution: ifrik commented 31 January 2017 at 15:46

Thanks, that sounds like a good approach.

When writing up the issue, I wasn't quite sure what was intended behaviour or what might be unintended. And it's probably the worst issue title I ever came up with, so I would welcome a better title.

Comment #5

tkoleary CreditAttribution: tkoleary at Acquia commented 9 February 2017 at 17:43

@ifrik Thx!

Comment #6

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 12 April 2017 at 10:16

Category:	Feature request	» Bug report
Issue tags:		+Usability

Comment #7

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 19 July 2017 at 20:45

Comment #8

19 July 2017 at 20:45

Version:

8.4.x-dev

» 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #9

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow at Acquia commented 30 August 2017 at 20:01

Component:

outside_in.module

» settings_tray.module

Changing to new settings_tray.module component. @drpal thanks for script help! :)

Comment #10

30 August 2017 at 20:01

Version:

8.5.x-dev

» 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #11

30 August 2017 at 20:01

Version:

8.6.x-dev

» 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #12

30 August 2017 at 20:01

Version:

8.7.x-dev

» 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #13

30 August 2017 at 20:01

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #14

30 August 2017 at 20:01

Version:

8.9.x-dev

» 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #15

30 August 2017 at 20:01

Version:

9.1.x-dev

» 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Comment #16

30 August 2017 at 20:01

Version:

9.2.x-dev

» 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #17

30 August 2017 at 20:01

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #18

30 August 2017 at 20:01

Version:

9.4.x-dev

» 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #19

30 August 2017 at 20:01

Version:

9.5.x-dev

» 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #20

mstrelan CreditAttribution: mstrelan at PreviousNext commented 9 January 2023 at 22:51

Status:	Active	» Postponed (maintainer needs more info)
Issue tags:		+Bug Smash Initiative

Is this still relevant for core now that Quick Edit module is in contrib?

If a user uses the quick edit mode by just clicking on a contextual link, then saving the changes, or closing the settings tray should return them to the normal mode.

This sounds like it should be addressed in Quick Edit module.

If one of the menus (Manage, Shortcuts, User) are enabled when a users clicks on a quick-edit link, then they need to be enabled again when the user leaves that mode.

As above

The "Editing" label should be replaced with a label that describes what will happen when the link is clicked to be consistent with other labels.

I can't find the "Editing" label in Drupal 10.1 with or without Quick Edit contrib, is this perhaps outdated?

Comment #21

9 January 2023 at 22:51

Version:

10.1.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.