Denmark's Address Web API (DAWA) provides data and functionality to Denmark addresses, access addresses, street names and postcodes.
This modules provides a field type, an autocomplete field widget and formatter to request and store addresses and access addresses from DAWA service.
https://dawa.aws.dk/
Under the hood Address DAWA Field stores the following information.
UUID : UUID of the address from DAWA service.
Type : Address type, It can be adresse (an address) or adgangsadresse (an access address).
Status : Status of the address from DAWA service.
Lat, Lng : Geo coordinates of the address.
Data : serialised data fetched from DAWA service.
Address DAWA field widget is an autocomplete text field fetching either address or access address, which can be configured on at the field settings page.
This project is sponsored by Forenede Danske Motorjere (FDM).
Git clone command
git clone --branch 8.x-1.x https://git.drupal.org/sandbox/yonas/2847411.git address_dawa
Project page
https://www.drupal.org/sandbox/yonas/2847411
pareview.sh
https://pareview.sh/node/916
Manual reviews of other projects:
https://www.drupal.org/node/2851740#comment-11944669
https://www.drupal.org/node/2847414#comment-11944617
https://www.drupal.org/node/2847717#comment-11944678
Comments
Comment #2
PA robot CreditAttribution: PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
zyyz CreditAttribution: zyyz as a volunteer and commentedComment #4
zyyz CreditAttribution: zyyz as a volunteer and commentedComment #5
zyyz CreditAttribution: zyyz as a volunteer and commentedComment #6
meickolAutomated Review
There are some errors reported by automated review tools, did you already check them?
Codespell has found some spelling errors in your code.
./tests/src/FunctionalJavascript/AddressDawaFieldTest.php:127: adress ==> address
See https://pareview.sh/node/916
Manual Review
nothing to add.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #7
meickolComment #8
klausiThat single spelling mistake is surely not an application blocker. Anything else that you found or should this be RTBC instead?
Comment #9
meickolNothing else, looks good for me.
Comment #10
zyyz CreditAttribution: zyyz as a volunteer and commentedComment #11
zyyz CreditAttribution: zyyz as a volunteer and commentedComment #12
zyyz CreditAttribution: zyyz as a volunteer and commentedHi meickol and klausi
Thanks a lot for the comments, I have now corrected the errors reports at pareview.sh
Comment #13
zyyz CreditAttribution: zyyz as a volunteer and commentedComment #14
meickolComment #15
zyyz CreditAttribution: zyyz as a volunteer and commentedComment #16
klausimanual review:
Otherwise looks good to me.
Thanks for your contribution, Yonas!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #17
klausiAssigning issue credits.