(Filling this as a followup to #2842064: Form widget shows HTML in label as plain text in the Entity Browser queue)

Right now, ContentTranslationHandler::addTranslatibilityQueue is adding the translatibility clue to a large range of items, including the details one. As is though, Details '#title' content is supposed to only contains plain text ; when being fed a span, it'll be displayed as is to the site contributor.

Not sure yet if this belongs to the content_translation component, to not add a span for things that should be plain text, or to the the form system one, to make details more in line with fieldset, and let it allow markup in the summary the way it allows for markup in the legend.

Steps to reproduce

As is, this is tricky to reproduce using core only, there's no field widget that directly expose a details element. Current steps to reproduce using Entity Browser:

  1. Install Entity Browse
  2. Set up a multilingual Drupal, enable content translation
  3. Set up content content translation for the Article node type
  4. Create an entity reference field on the Article node type, make it untranslatable
  5. Set the widget for that entity reference field to use the entity browser widget
  6. Create a node
  7. Add a translation for that node

At that point, the widget title will be the field name, suffixed by all languages, with the span being displayed.

CommentFileSizeAuthor
#18 2847131-18-details-allow-html-in-summary.patch2.42 KBR.Muilwijk
#14 2847131-14-details-allow-html-in-summary.patch2.43 KBbalagan
#12 2847131-12-details-allow-html-in-summary.patch2.43 KBlammensj
#9 2847131-6-details-allow-html-in-summary.patch2.39 KBvurt
#5 2847131-5-details-allow-html-in-summary-TEST-ONLY.patch1.52 KBthenchev
#5 2847131-5-details-allow-html-in-summary.patch2.4 KBthenchev
#2 2847131-2-details-allow-html-in-summary.patch895 bytesDeFr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DeFr created an issue. See original summary.

DeFr’s picture

DeFr CreditAttribution: DeFr at Axess Open Web Services commented
Component: content_translation.module » forms system
Status: Active » Needs review
FileSize
2847131-2-details-allow-html-in-summary.patch895 bytes

Attached patch fixes the problem by making the details summary element more in line with the fieldset legend, allowing HTML tags, so switching component. Not sure that's really the way to go though.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Needs review » Needs work
Issue tags: +D8Media, +Needs tests

Solution looks OK to me, but I assume committers will require test coverage for it.

thenchev’s picture

thenchev CreditAttribution: thenchev commented
Status: Needs work » Needs review
FileSize
2847131-5-details-allow-html-in-summary.patch2.4 KB
2847131-5-details-allow-html-in-summary-TEST-ONLY.patch1.52 KB

Added test coverage.

Status: Needs review » Needs work

The last submitted patch, 5: 2847131-5-details-allow-html-in-summary-TEST-ONLY.patch, failed testing.

thenchev’s picture

thenchev CreditAttribution: thenchev commented
Status: Needs work » Needs review
gngn’s picture

gngn CreditAttribution: gngn at Computer Manufaktur GmbH commented

Works for me and looks ok to me (hand applied to an old 8.2 core).

I think this really looks annoying (for an example see the image https://www.drupal.org/files/issues/Entity-browser-label.png attached to the original entity browser issue.
So I would be glad if this gets commited.

vurt’s picture

vurt CreditAttribution: vurt as a volunteer and at Computer Manufaktur GmbH commented
FileSize
2847131-6-details-allow-html-in-summary.patch2.39 KB

I rerolled the patch so that it works with a current version (8.3.4).

idebr’s picture

idebr CreditAttribution: idebr commented
Issue tags: -Needs tests
Related issues: +#2652850: Title for details form elements is not set as '#markup' and it will be escaped, but all other form elements use '#markup' and are not escaped

The problem and the proposed resolution for this issue overlap with the related issue #2652850: Title for details form elements is not set as '#markup' and it will be escaped, but all other form elements use '#markup' and are not escaped. Since this issue has test coverage, I propose the related issue is closed as a duplicate.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

lammensj’s picture

lammensj CreditAttribution: lammensj commented
FileSize
2847131-12-details-allow-html-in-summary.patch2.43 KB

Rerolled the patch against 8.4.x

Status: Needs review » Needs work

The last submitted patch, 12: 2847131-12-details-allow-html-in-summary.patch, failed testing. View results

balagan’s picture

balagan CreditAttribution: balagan at Brainsum commented
FileSize
2847131-14-details-allow-html-in-summary.patch2.43 KB

I have experienced same behaviour with an untranslatable Date field on a multilingual site. Rerolled the patch against 8.5.x

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

rwam’s picture

rwam CreditAttribution: rwam commented

Thank you, patch #14 applied successful and works fine with 8.5.1. I have problems with the patches provided in https://www.drupal.org/project/drupal/issues/2652850 so I will use this one.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

R.Muilwijk’s picture

R.Muilwijk CreditAttribution: R.Muilwijk at iO commented
FileSize
2847131-18-details-allow-html-in-summary.patch2.42 KB

Reroll on 8.6

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Postponed (maintainer needs more info)

#2652850: Title for details form elements is not set as '#markup' and it will be escaped, but all other form elements use '#markup' and are not escaped was now committed, this should no longer be an issue now.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

pameeela’s picture

pameeela CreditAttribution: pameeela commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)
Issue tags: +Bug Smash Initiative

Thanks for reporting this issue. We rely on issue reports like this one to resolve bugs and improve Drupal core.

As part of the Bug Smash Initiative, we are triaging issues that are marked "Postponed (maintainer needs more info)".

Since there was no additional information provided since the issue was postponed or #2652850: Title for details form elements is not set as '#markup' and it will be escaped, but all other form elements use '#markup' and are not escaped was suggested as duplicate, I'm marking the issue "Closed (duplicate)". If anyone can provide information on why this issue is different, please add complete steps to reproduce the issue (starting from "Install Drupal core"), document those steps in the issue summary and set the issue status back to "Active".

Thanks!