#2843687: Block configuration forms are not submitted was created and resolved while I was working on fixing the same issue. However, I took a tests first approach and now have working test coverage for the issue. Would be a waste to throw away, so attached you'll find a patch containing said test.

CommentFileSizeAuthor
block-form-submission-test-coverage.diff12.01 KBlegolasbo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

legolasbo created an issue. See original summary.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: kristiaanvandeneynde at Deeson commented

Only nitpick I could find regarding createAdminUser():
I think you can flag a role as admin, making it have all permissions all the time. Your version is shorter, though.

Looks great otherwise. If you'd like to keep the method as is, it's RTBC for me.

  • jrockowitz committed 4304901 on 8.x-1.x authored by legolasbo 
    Issue #2847084 by legolasbo, kristiaanvandeneynde: Follow up: Add test...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs review » Fixed

Thanks for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.