Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yoroy created an issue. See original summary.

jvsouto’s picture

jvsouto’s picture

Status: Active » Needs review
FileSize
928 bytes

Patch

Status: Needs review » Needs work

The last submitted patch, 3: remove-useless-descriptions-term-2847035-2.patch, failed testing.

jvsouto’s picture

Status: Needs work » Needs review

Oops!

The last submitted patch, 2: remove-useless-descriptions-term-2847035-2.patch, failed testing.

gaurav.kapoor’s picture

Patch corrected , clear cache before checking whether issue has been fixed or not.

gaurav.kapoor’s picture

Status: Needs review » Reviewed & tested by the community
yoroy’s picture

Thank you @jvsouto, that was fast :-)
@gaurav.kapoor, thanks for testing, but I don't see any difference between the last patch @jvsouto posted and yours?

Visual proof via simplytest.me:

RTBC indeed.

claudiu.cristea’s picture

@gaurav.kapoor, please stop re-posting patches without changing nothing. I see you did the same with https://www.drupal.org/node/2845644#comment-11888724 and https://www.drupal.org/node/2845483#comment-11888727

gaurav.kapoor’s picture

@claudiu.cristea i am new to drupal , i read the correct patch format in the documentation and renamed patches with that format.I wont repost any patches now.

gaurav.kapoor’s picture

..

gaurav.kapoor’s picture

yoroy’s picture

Thanks for explaining @gaurav.kapoor. It's good to use the preferred naming format for patches but it's not necessary to repost other peoples patches just to change the name.

jvsouto’s picture

Thank you guys!
Sorry for not writing the title as in the documentation.

  • catch committed 98c5bd3 on 8.3.x
    Issue #2847035 by jvsouto, yoroy: Remove useless descriptions on...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.3.x, thanks!

  • catch committed 98c5bd3 on 8.4.x
    Issue #2847035 by jvsouto, yoroy: Remove useless descriptions on...

  • catch committed 98c5bd3 on 8.4.x
    Issue #2847035 by jvsouto, yoroy: Remove useless descriptions on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.