UIkit project page

git clone --branch 7.x-2.x https://git.drupal.org/project/uikit.git

UIkit is a lightweight and modular front-end framework for developing fast and powerful web interfaces. This project has been ported to Drupal from the popular theme provider YOOTHEME. I have taken over the uikit namespace on drupal.org from the original maintainer and am applying to gain full project status.

Manual reviews of other projects

These are three reviews I have submitted to other project applications in order to receive a Review bonus to prioritised my application of the UIkit theme in the project application queue.

Thanks for your help in prioritizing my application to promote full projects!

CommentFileSizeAuthor
#5 coder-results.txt35.5 KBklausi
#2 uikit-screenshot.png168.23 KBRichard Buchanan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Richard Buchanan created an issue. See original summary.

Richard Buchanan’s picture

Richard Buchanan CreditAttribution: Richard Buchanan as a volunteer commented
Issue summary: View changes
FileSize
uikit-screenshot.png168.23 KB
PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectuikitgit

I'm a robot and this is an automated message from Project Applications Scraper.

Richard Buchanan’s picture

Richard Buchanan CreditAttribution: Richard Buchanan as a volunteer commented
Status: Needs work » Needs review

Fixed PHP CodeSniffer issues.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Needs review » Needs work
Issue tags: -PAreview: review bonus
FileSize
coder-results.txt35.5 KB

Review of the 7.x-2.x branch (commit 38a5d35):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards). See attachment.
  • Codespell has found some spelling errors in your code.
    ./uikit_core/includes/preprocess.inc:706: accordian  ==> accordion
./uikit_core/js/uikit.admin.js:29: compatibilty  ==> compatibility
./uikit_core/docs/api/uikit.api.php:35: commited  ==> committed
./uikit_core/docs/api/uikit.api.php:65: originall  ==> original, originally
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

  1. why is there a templates folder and a theme folder? The theme folder also contains templates? Shouldn't they all go into the templates folder?
  2. FontAwesome.otf appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms. Instead you should tell in the installation instructions where to download that font.
  3. uikit-subtheme.js: do not use jQuery(document).ready(), use Drupal.behaviors instead. See https://www.drupal.org/node/756722#behaviors

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Richard Buchanan’s picture

Richard Buchanan CreditAttribution: Richard Buchanan as a volunteer commented
Status: Needs work » Needs review
Issue tags: +PAreview: review bonus

Thanks for the review klausi! The issues mentioned have been corrected.

  1. The uikit_core/theme folder was originally being used for templates not provided by Drupal core, some of them theme_HOOK() hooks. The uikit_core/templates folder was where I placed template files taken from Drupal core modules. I removed the uikit_core/theme folder and moved the template files to their respective theme hooks in uikit_core/includes/theme.inc.
  2. I removed the fonts folder completely, I simply forgot to remove it earlier in development. The Font Awesome assets are now retrieved from cdnjs in uikit_core/includes/get.inc.
  3. uikit_subtheme/js/uikit-subtheme.js behaviors suggestion has been implemented.

I also performed three more application reviews for the following projects to add the review bonus tag again:

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Needs review » Fixed

Looks good to me!

Thanks for your contribution, Richard!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Richard Buchanan’s picture

Richard Buchanan CreditAttribution: Richard Buchanan as a volunteer commented

Thanks klausi! Will review the materials you provided and continue to stay involved in the review process.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented

Assigning issue credits.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.