CommentFileSizeAuthor
#4 this_t_should_be-2846172-4.patch6.74 KBaadil.addweb
#2 Search_api_location_2846172_1.patch5.19 KBnehakhadke
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke CreditAttribution: nehakhadke at Invezza Technologies commented
FileSize
Search_api_location_2846172_1.patch5.19 KB
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Needs review » Needs work

This patch doesn't apply to any version of this module that I can find. (And there are just four of them in D8.)
Can you please try and re-roll?

aadil.addweb’s picture

aadil.addweb CreditAttribution: aadil.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs work » Needs review
FileSize
this_t_should_be-2846172-4.patch6.74 KB

Please apply this_t_should_be-2846172-4.patch.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Needs review » Fixed

Ah, thanks. Looks good and makes sense.
Committed.
Thanks again, both of you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

caldenjacobs’s picture

caldenjacobs CreditAttribution: caldenjacobs commented

I'm getting the following fatal error, related to this patch/commit:

Fatal error: Using $this when not in object context in modules/contrib/search_api_location/search_api_location_views/search_api_location_views.module on line 30

EDIT:

My bad, this was actually an issue with the patch located here (don't use it!): https://www.drupal.org/node/2855157#comment-11952595

Solved by the explanation here: https://www.drupal.org/node/2855157#comment-12018274

Apologies for the confusion :)