Config dependency should be added only for required config

Updated the patch so that it also skips inter-package dependencies for optional config.

Sorry, missed a line in that last patch.

Ugh. I tested it and it was working, but then I did some formatting to make the code more readable and messed things up. Sorry about that. This time, I retested before uploading the patch.

Triggered a new test now that the Features branch is working again.

Not sure why the testbot doesn't give useful results, but here is the test result when I run it locally:

% ../vendor/bin/phpunit ../modules/features/tests/src/Unit/FeaturesManagerTest.php --verbose
PHPUnit 4.8.27 by Sebastian Bergmann and contributors.

Runtime: PHP 7.0.15
Configuration: /Users/mpotter/Projects/d8/docroot/core/phpunit.xml.dist

........FF....E...............

Time: 857 ms, Memory: 10.00Mb

There was 1 error:

1) Drupal\Tests\features\Unit\FeaturesManagerTest::testAssignConfigPackageWithNonProviderExcludedConfig
Error: Call to a member function getType() on boolean

/Users/mpotter/Projects/d8/docroot/modules/features/src/FeaturesManager.php:570
/Users/mpotter/Projects/d8/docroot/modules/features/src/FeaturesManager.php:620
/Users/mpotter/Projects/d8/docroot/modules/features/tests/src/Unit/FeaturesManagerTest.php:438

--

There were 2 failures:

1) Drupal\Tests\features\Unit\FeaturesManagerTest::testAssignInterPackageDependenciesWithoutBundle
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
- 0 => 'my_other_feature'
- 1 => 'package2'
)

/Users/mpotter/Projects/d8/docroot/modules/features/tests/src/Unit/FeaturesManagerTest.php:260

2) Drupal\Tests\features\Unit\FeaturesManagerTest::testAssignInterPackageDependenciesWithBundle
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
- 0 => 'giraffe_package2'
- 1 => 'my_other_feature'
)

/Users/mpotter/Projects/d8/docroot/modules/features/tests/src/Unit/FeaturesManagerTest.php:308

FAILURES!
Tests: 30, Assertions: 63, Errors: 1, Failures: 2.

So some work on this is still needed.

Rerolled this against the latest version of dev.

Removed the last part because it was already added it appears.

-        if (!empty($config_collection[$item_name]->getData()['dependencies']['config'])) {
+        $subdirectory = $config_collection[$item_name]->getSubdirectory();
+        if (!empty($config_collection[$item_name]->getData()['dependencies']['config']) && $subdirectory === InstallStorage::CONFIG_INSTALL_DIRECTORY) {

Also had to change
$provider = $this->entityManager->getDefinition($type)->getProvider();

To

$provider = $this->entityTypeManager->getDefinition($type)->getProvider();

Very small tweak but appears to be working after initial testing.

I don't understand Drupal 8 unit testing well enough to know why it's failing.