Currently, line 57 of webform/js/webform.element.other.js consists of the following:
var $select = $element.find('.form-type-select');

However, not all themes actually add the class "form-type-select"; Basic, for example, currently adds "form-select". Wouldn't it be more future-proof to just look for the select element instead?
var $select = $element.find('select');

Am I missing something obvious? That's what the checkbox and radio "other" fields do.

If not, I'll roll a patch.

Comments

CatherineOmega created an issue. See original summary.

jrockowitz’s picture

Status: Active » Fixed

Make sense to me. I committed the change. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.