Missing a space between two sentences

Patch with correct format uploaded , working and tested.

For me, with the patch, there are two spaces between the paragraphs.

#7 looks good.

Which patch is rbtc? I think the patch called 2845644-7.patch is more correct. Adding a space at the end of the sentence just hanging there is really odd. It also means that there is no translatable string change and the issues around RTL languages are better.

Can someone please clarify and think about what's best here.

It looks like we are aiming for 2845644-7.patch :-)

@vaplas: can you confirm that you rolled 2845644-7.patch against Drupal 8.4.x-dev?

Sorry for the confusion in #7 , "2845644-7.patch" : tested this patch , works fine in both 8.3.x and 8.4.x . So marking it back as RTBC. It changes the way the info is displayed to very clean way.

So I reviewed #7 (the first one) with git diff --color-words and confirmed that it properly wraps paragraphs in <p> tags, rather than using the <br /> which is nonstandard. That also means it does not change any translatable strings by fixing the markup, which is good.

However, it is also changing the quoting on the second string from single to double quotes. This avoids having to escape the apostrophe, but is slightly out of scope. I can't remember whether the translatable strings are parsed by PHP or not right now (i.e., will changing the \' to ' be picked up as a string change that translators need to retranslate). Checking on that now.

The patch does not affect grammar, only whitespace.

Okay, I actually dug into potx to answer this question:
http://cgit.drupalcode.org/potx/tree/potx.inc#n709

Strings with no placeholders are identified by looking for T_CONSTANT_ENCAPSED_STRING. Then:

/**
 * Escape quotes in a strings depending on the surrounding
 * quote type used.
 *
 * @param $str
 *   The strings to escape
 */
function _potx_format_quoted_string($str) {
  $quo = substr($str, 0, 1);
  $str = substr($str, 1, -1);
  if ($quo == '"') {
    $str = stripcslashes($str);
  }
  else {
    $str = strtr($str, array("\\'" => "'", "\\\\" => "\\"));
  }
  return addcslashes($str, "\0..\37\\\"");
}

So, they should end up as the same thing, but that wasn't a sure thing.

In the future though, probably best to avoid changing the string's quotation method in another fix, to avoid out of scope changes. See https://www.drupal.org/core/scope for lots of background information on why scope is important, even for small things.

Wrapping any paragraph in paragraph tags ensures that HTML handles the whitespace, and is our standard, so agreed that it is the best fix. In the future let's be sure to upload the intended fix as the last attachment to the issue and avoid even small changes to code that is not part of the fix.

Since this ended up just being a small markup bugfix, without a translatable string change, and since we are still in alpha, I backported it to 8.3.x also to avoid unnecessary divergence.

Thanks everyone! Committed to 8.4.x and 8.3.x.

Sorry, d.o ate the credit I had saved for this issue, so reverting and recommitting.

I don't understand why there is inconsistency in using single and double quotes in help text for content translation and language module. Shouldn't this also be standardised ?