I think this new update breaks the burger menu on Bootstrap theme (https://www.drupal.org/project/bootstrap) because when i updated it, i was no longer able to click on the burger menu.

So i revert back to the last version of this module and everything was working again.

Comments

duvien created an issue. See original summary.

RdeBoer’s picture

RdeBoer
Location Melbourne
CreditAttribution: RdeBoer commented

@duvien
Can you please provide some details?
Which version did you revert to?
Which new version did you try (we released 2 in quick succession)
Did you see any errors in the browser console?
Rik

onejam’s picture

onejam CreditAttribution: onejam commented

I used:

Drupal 7.53
bootstrap 7.x-3.10
Leaflet Markercluster 7.x-1.4

and bootstrap burger menu stopped working.

No js error where shown, i don't think?. Usually, when you click the burger menu, the js appends a class to it but it just didn't registered at all.

Reverting back to leaflet_markercluster 7.x-1.3, it seems to be fine.

Which new version did you try (we released 2 in quick succession)

i'm not sure? as i only see 7.x-1.4 and that was the latest version i updated to, which gave me the issue.

cheers,

RdeBoer’s picture

RdeBoer
Location Melbourne
CreditAttribution: RdeBoer commented

Thanks for the additional info. The differences between Leaflet MarkerCluster versions 7.x-1.3 and 7.x-1.4 are minimal.
I'll dig deeper as soon as I have time, but the only difference between the latest 2 releases is in relation to a reversed patch for an issue with multiple maps on the same page. Nothing to do with CSS classes or menus.

What version of Leaflet JS and Leaflet MarkerCluster are you using?
With the latest versions of the Leaflet & Leaflet MarkerCluster Drupal modules I recommend LeafletJS 1.0.2 and Leaflet MarkerCuster JS 1.0.0.

onejam’s picture

onejam CreditAttribution: onejam commented

I'm using LeafletJS 1.0.2

cheers,

RdeBoer’s picture

RdeBoer
Location Melbourne
CreditAttribution: RdeBoer commented

Hmm... that's what I'm using too. Latest versions of everything, and I'm using bootstrap 7.x-3.10.

See for instance this site, which also uses bootstrap 3.10 and latest Leaflet + JS 1.0.2 and latest Leaflet MarkerCluster + JS 1.0.0:
https://regionbound.com/coffee-prices-across-melbourne

There must be something more going on on your site. Suggest you check your browser console for JS errors.

Do you have more than one clustered map on the same page?

onejam’s picture

onejam CreditAttribution: onejam commented

Hmm? i think your right. I noticed on further testing some pages on my site, the bootstrap burger menu works fine. I'll dig further to find out the cause.

cheers,

onejam’s picture

onejam CreditAttribution: onejam commented
Status: Active » Closed (cannot reproduce)
RdeBoer’s picture

RdeBoer
Location Melbourne
CreditAttribution: RdeBoer commented

Great. All good.
Thanks.