/**
   * Implementation of MigrateSource::performRewind().
   *
...
   */
  protected function initializeIterator() {

That's not performRewind...

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

Anonymous’s picture

dgagne’s picture

Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2845324-2.patch, failed testing.

dgagne’s picture

Status: Needs work » Reviewed & tested by the community

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 84b2d06 to 8.4.x and 2061bfd to 8.3.x. Thanks!

  • alexpott committed 84b2d06 on 8.4.x
    Issue #2845324 by vaplas: error in docs in SqlBase::initializeIterator()
    

  • alexpott committed 2061bfd on 8.3.x
    Issue #2845324 by vaplas: error in docs in SqlBase::initializeIterator...
alexpott’s picture

+++ b/core/modules/migrate/src/Plugin/migrate/id_map/Sql.php
@@ -818,7 +818,7 @@ public function destroy() {
-   * Implementation of Iterator::rewind().
+   * Implementation of \Iterator::rewind().

I originally felt that these changes where out-of-scope but the later changes to SourcePluginBase::rewind() are in scope and this keeps everything consistent.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.