Hello,

I am currently testing the social API initiative and looking on the code.

I found that in FacebookAuthController, redirectToFb(), there is a variable $fb_login_url that is redefined and so the first calculation is never used.

http://cgit.drupalcode.org/sandbox-gvso-2840522/tree/src/Controller/Face...

I think it is the last variable definition that should be removed.

Can I provide a patch?

Also the social API seems not to work with local dev sites.

CommentFileSizeAuthor
#4 social_auth_facebook-redifined_var-2845312-4.patch909 bytesGrimreaper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Grimreaper created an issue. See original summary.

gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In commented

Hi @Grimreaper! Thanks for reporting this. Please feel free to provide a patch. Ideas and patches are always more than welcome.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Assigned: Unassigned » Grimreaper

Ok.

I will provide a patch when I will get a little time.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Assigned: Grimreaper » Unassigned
Status: Active » Needs review
FileSize
social_auth_facebook-redifined_var-2845312-4.patch909 bytes

Here is the patch.

I could not have tested it.

Thanks for the review.

  • gvso committed fb675aa on 8.x-1.x 
    Issue #2845312 by Grimreaper: $fb_login_url variable redefined
gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In commented
Status: Needs review » Fixed

Good catch. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.