Profile still uses the old permission code, which moved to Commerce, then moved to Entity API, and got many bug fixes along the way.
We need to rip the current code out, start using the Entity API one.

Should fix issues like #2815273: Edit permission has no effect.

CommentFileSizeAuthor
#13 start_using_the_entity-2844908-13.patch24.09 KBmglaman
#6 start_using_the_entity-2844908-6.patch24.52 KBmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Priority: Normal » Major
Related issues: +#2810525: Harmonization of operation names in access control handler is done too late, +#2820209: Allow anonymous users to view Profiles, +#2817735: Access Denied on Profile view by users with 'view profile' permission

Linking related issues. First step is to get test failures that reprelicate reported issues. Then implement code and see that it passes.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Issue tags: +MidCamp2017
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented

Worked on this during train ride. Proposed change record once I work out the last few issues: https://www.drupal.org/node/2866124

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Related issues: +#2854336: Private fields are visible to any user with view access to the profile

Refactoring this caused #2854336: Private fields are visible to any user with view access to the profile to fail.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
FileSize
start_using_the_entity-2844908-6.patch24.52 KB

Here is first patch. It uncovered issues that we have in the queue. Instead of fixing here I commented those items out with @todo

mglaman credited agoradesign.

mglaman credited kscheirer.

mglaman credited nedjo.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented

Contributing others, because thanks for finding the other bugs :)

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: start_using_the_entity-2844908-6.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs work » Needs review
FileSize
start_using_the_entity-2844908-13.patch24.09 KB

Fixed the kernel test

  • mglaman committed cf52c8a on 8.x-1.x 
    Issue #2844908 by mglaman, bojanz, agoradesign, kscheirer, nedjo: Start...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs review » Fixed

Okay! Huge step forward, now for the other follow ups.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.