Problem/Motivation
The class form-group
gets added to the div representing the focal point. We show the form using our main theme, which applies a bottom margin with this class (Bootstrap), making the preview image offset from the marker by about 15px.
The focal marker div is currently built by creating a render array with an empty markup and wrapping it using the "container" render element. This not only feels semantically incorrect to me, as there is no actual group of form elements to wrap, and a bit verbose as all kinds of classes get applied to the container by default (including form-group
).
Proposed resolution
Build the marker with '#type' => 'html_tag'
instead. No extra classes and more semantically correct result.
Comment | File | Size | Author |
---|---|---|---|
focal_point-wrapper.patch | 829 bytes | TwoD | |
|
Comments
Comment #2
guile2912 CreditAttribution: guile2912 as a volunteer commentedWorks like a charm, thanks a lot for the patch
Comment #3
bleen CreditAttribution: bleen at NBCUniversal commentedThis seems reasonable to me ... thanks for the patch!
Comment #5
bleen CreditAttribution: bleen at NBCUniversal commentedComment #6
bleen CreditAttribution: bleen at NBCUniversal commented