Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #2826688: Link fields should pass the URL, not only the title
Problem/Motivation
When URLs are translated with Lingotek, we must validate them before storing. This is specially relevant when users are using automatic translations.
Proposed resolution
Validate the URIs before saving. If they are invalid, log a warning and store the same URI as the source.
Remaining tasks
Fix + tests
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff.txt | 19.47 KB | penyaskito |
#4 | 2844532-uris-validation-4.patch | 19.37 KB | penyaskito |
| |||
#4 | 2844532-uris-validation-4.only-tests.patch | 15.38 KB | penyaskito |
Comments
Comment #2
penyaskitoWork in progress, some tests fail with the fallback of the original source uris.
Comment #4
penyaskitoFound the problem, we were not assigning the original alias correctly. Also found some issues when an exception is thrown, the right message was not shown because we were returning TRUE.
Comment #7
penyaskitoFixed branch tests at #2846203: Fix build after Content Cloud Beta was committed, let's requeue them
Comment #8
penyaskitoTests passed and failed as expected.
Comment #10
penyaskitoCommitted 6da647e and pushed to 8.x-1.x. Thanks!
Fixed phpcs errors on commit. Interdiff attached.