Problem/Motivation

Follow-up to #2828846: Add the option of editing the Lingotek locale on language forms. After that change, Drupal language form throws an exception when downloading translations. This only happens when downloading translations is enabled, which is disabled by default in tests. That's why we didn't catch this bug before.

 [client ::1:50244] Uncaught PHP Exception Exception: "Serialization of 'Closure' is not allowed" at core/lib/Drupal/Core/Batch/BatchStorage.php line 157, referer: /admin/config/regional/language/add

Proposed resolution

Fix the serialization problem by using function names instead of the closure.

Remaining tasks

Patch with tests.

User interface changes

None.

API changes

None

Data model changes

None.

CommentFileSizeAuthor
#2 2844347-2.patch3.87 KBpenyaskito
#2 2844347-2.only-tests.patch1.08 KBpenyaskito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2844347-2.only-tests.patch1.08 KB
2844347-2.patch3.87 KB

Modified test for catching the issue, added fix.

The last submitted patch, 2: 2844347-2.only-tests.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Needs review » Reviewed & tested by the community

Patches passed and failed as expected.

  • penyaskito committed 64d80aa on 8.x-1.x 
    Issue #2844347 by penyaskito: Error when downloading locales after...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Reviewed & tested by the community » Fixed

Committed 64d80aa and pushed to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.