Problem/Motivation

There a lot of places where we need the translation langcodes of an entity but in order to retrieve them we always do
array_keys($entity->getTranslationLanguages())

As we do not always need the language objects but only the language codes it would be useful to have a method returning only them.

Proposed resolution

New method TranslatableInterface::getTranslationLangcodes.

Remaining tasks

Review.

User interface changes

None.

API changes

New method TranslatableInterface::getTranslationLangcodes.

Data model changes

None.

CommentFileSizeAuthor
#25 interdiff_16_25.txt594 bytesRishabh Vishwakarma
#25 2844222-25.patch2.04 KBRishabh Vishwakarma
#24 2844222-nr-bot.txt2.07 KBneeds-review-queue-bot
#23 interdiff_16_23.txt528 bytesRishabh Vishwakarma
#23 2844222-23.patch2.08 KBRishabh Vishwakarma
#22 interdiff_16-22.txt634 bytesrishabh064
#22 2844222-22.patch2.08 KBrishabh064
#16 2844222-16.patch2.08 KBsmustgrave
#16 interdiff-2-16.txt3.28 KBsmustgrave
#2 2844222-2.patch2.18 KBhchonov

Issue fork drupal-2844222

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hchonov created an issue. See original summary.

hchonov’s picture

hchonov
Primary language Bulgarian
Location 🇪🇺🇩🇪🇧🇬
CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented
FileSize
2844222-2.patch2.18 KB
hchonov’s picture

hchonov
Primary language Bulgarian
Location 🇪🇺🇩🇪🇧🇬
CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented
Issue tags: +D8MI

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented

I'm not sure if this is a BC break, if it doesn't this looks very good and I think that this is a useful new addition.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
FileSize
interdiff-2-16.txt3.28 KB
2844222-16.patch2.08 KB

Rerolled for 9.5

Curious to see if it breaks anything but agree with #7 looks like a good change.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work
Issue tags: +Needs change record, +Novice, +Needs Review Queue Initiative

new function should be typehinted.
Change record should be added also.

Should be simple for someone to do.

royalpinto007 made their first commit to this issue’s fork.

royalpinto007’s picture

royalpinto007
he/him
Primary language English
CreditAttribution: royalpinto007 commented
Assigned: Unassigned » royalpinto007
royalpinto007’s picture

royalpinto007
he/him
Primary language English
CreditAttribution: royalpinto007 commented
Assigned: royalpinto007 » Unassigned
rishabh064’s picture

rishabh064 CreditAttribution: rishabh064 at OpenSense Labs for DrupalFit commented
FileSize
2844222-22.patch2.08 KB
interdiff_16-22.txt634 bytes

I've added type hint in the new method as per the comment #18, please review.

Still need work for change record.

Rishabh Vishwakarma’s picture

Rishabh Vishwakarma CreditAttribution: Rishabh Vishwakarma at OpenSense Labs for DrupalFit commented
Status: Needs work » Needs review
FileSize
2844222-23.patch2.08 KB
interdiff_16_23.txt528 bytes

Typehinted the new function as mentioned in #18.

needs-review-queue-bot’s picture

needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commented
Status: Needs review » Needs work
FileSize
2844222-nr-bot.txt2.07 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Rishabh Vishwakarma’s picture

Rishabh Vishwakarma CreditAttribution: Rishabh Vishwakarma at OpenSense Labs for DrupalFit commented
Status: Needs work » Needs review
FileSize
2844222-25.patch2.04 KB
interdiff_16_25.txt594 bytes

Typehinted the new function as mentioned in #18.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Needs work

#[\ReturnTypeWillChange]
This tells us that the return type will be different soon. This is completely new code, so this is not the correct way to mark this.

It needs to be array, in both the interface and the implementation I think?

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.