Problem/Motivation

We can improve one of our tests to resolve a @todo with testing the labels of the edit tabs.

Proposed resolution

Add tests.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 2843997-tab-label-coverage-3.patch3.09 KBSam152
#3 interdiff.txt1.81 KBSam152
#2 2843997-tab-label-coverage-2.patch2.21 KBSam152
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Active » Needs review
FileSize
2843997-tab-label-coverage-2.patch2.21 KB
Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
FileSize
interdiff.txt1.81 KB
2843997-tab-label-coverage-3.patch3.09 KB

May as well get the other tab @todo while we're here.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Issue tags: +Workflow Initiative
jeqq’s picture

jeqq
Primary language Romanian
CreditAttribution: jeqq for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2843997-tab-label-coverage-3.patch, failed testing.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Reviewed & tested by the community

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

cilefen’s picture

cilefen CreditAttribution: cilefen commented 
+++ b/core/modules/content_moderation/tests/src/Functional/LocalTaskTest.php
@@ -59,20 +61,35 @@ protected function setUp() {
+    $this->drupalGet(sprintf('node/%s', $this->testNode->id()));

Would it not be simpler to concatenate in this test code instead of sprintf? Let's open a novice task to replace this and other similar stuff in the test.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue tags: +Needs followup

.. and by the way, we can still commit this as-is.

  • cilefen committed 4ffb98e on 8.4.x 
    Issue #2843997 by Sam152: Add missing test coverage for content edit tab...

  • cilefen committed 2a7ec1a on 8.3.x 
    Issue #2843997 by Sam152: Add missing test coverage for content edit tab...
cilefen’s picture

cilefen CreditAttribution: cilefen commented

Thank you! We backported this to 8.3.x because it is a test improvement to an experimental module.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Reviewed & tested by the community » Fixed
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: +DrupalCampNJ2017
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 8.4.x-dev » 8.3.x-dev

(Since it was backported as experimental module tests).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.