This is a minor fix

I have been following some recent overnight changes to the examples module and noticed that they have started to namespace their dependencies.

Here is the relevant documentation

https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...

From which is see the following quote suggesting that the proper format is {project}:{module}

dependencies - A list of other modules your module depends on. Dependencies should be namespaced in the format: {project}:{module} where {project} is the project name as it appears in the Drupal.org url (i.e: drupal.org/project/views) and {module} is the module's machine name.

CommentFileSizeAuthor
#8 monday-2843798-8.patch914 bytesmartin107
#6 namespace-2843708-6.patch1.09 KBmartin107
#2 namespace-2843708-2.patch747 bytesmartin107
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107 created an issue. See original summary.

martin107’s picture

martin107 CreditAttribution: martin107 commented
FileSize
namespace-2843708-2.patch747 bytes
martin107’s picture

martin107 CreditAttribution: martin107 commented
Status: Active » Needs review
joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Needs work 
+++ b/modules/flag_follower/flag_follower.info.yml
@@ -4,6 +4,6 @@ core: 8.x
+  - drupa:node

Typo ;)

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented 
+++ b/modules/flag_bookmark/flag_bookmark.info.yml
@@ -4,6 +4,6 @@ core: 8.x
 dependencies:
   - flag
-  - views
-  - node
+  - drupal:views
+  - drupal:node
 package: Flags

Why not update flag to flag:flag while you touch it?

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
namespace-2843708-6.patch1.09 KB

Thank you both

So before I submitted I was paranoid enough to manually test both submodules,

drush en flag_bookmark
drush en flag_followers

but my inability to spell drupal correctly has left me even more paranoid -- as something in core or drush let me install a module with unmeetable dependencies!

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work

That's because drupal itself doesn't care about projects, they don't exist at runtime, so it basically just drops whatever project definition you have in there. So drupal:node will install, drupa:node will install, foo:node will install... drupal:nod will not.

Looks like you added a submodule reference to the patch now :)

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
Status: Needs work » Needs review
FileSize
monday-2843798-8.patch914 bytes

Such a short patch, with so many corrections ... it must be Monday

Thanks for the clarification and keeping me honest Bedir

socketwench’s picture

socketwench CreditAttribution: socketwench commented
Status: Needs review » Reviewed & tested by the community

Ran install locally, no issues!

  • joachim committed 1ccf30b on 8.x-4.x authored by martin107 
    Issue #2843798 by martin107: Updated module dependencies to use project...
joachim’s picture

joachim CreditAttribution: joachim commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.