Problem/Motivation

Please refer the problem/motivation section of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method

Proposed resolution

Write EntityResourceTestBase subclass for the EntityFormDisplay entity.

Remaining tasks

References

1. Follow-up of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
2. Subtask of #2824572: Write EntityResourceTestBase subclasses for every other entity type.

CommentFileSizeAuthor
#11 2843764-11.patch10.9 KBWim Leers
#11 interdiff.txt1.67 KBWim Leers
#5 pp_1_entityresource_-2843764-5.patch11.61 KBshadcn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented

When you try to implement that you will run into: #2866666: Add proper access handlers for view and form displays in some form.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: EntityResource: Provide comprehensive test coverage for EntityFormDisplay entity » [PP-1] EntityResource: Provide comprehensive test coverage for EntityFormDisplay entity
Status: Active » Postponed
Related issues: +#2866666: Add proper access handlers for view and form displays
shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented
FileSize
pp_1_entityresource_-2843764-5.patch11.61 KB

What if we had access handlers like we did for the other entity types?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented

IMHO we should do more than just view permissions. You should be able to post to those entity types as well.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Well… POSTing config entities won't work anyway until #2300677: JSON:API POST/PATCH support for fully validatable config entities. But yes, I agree we want to do #286666: tagadelic_node_get_terms($node) may try to return an undefined variable (nice issue ID btw :D) first.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Issue tags: +php-novice, +API-First Initiative

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: [PP-1] EntityResource: Provide comprehensive test coverage for EntityFormDisplay entity » EntityResource: Provide comprehensive test coverage for EntityFormDisplay entity
Status: Postponed » Needs work

#2866666: Add proper access handlers for view and form displays landed, this is now unblocked!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs work » Reviewed & tested by the community
FileSize
interdiff.txt1.67 KB
2843764-11.patch10.9 KB

Straight rebase of #5 — since #2866666: Add proper access handlers for view and form displays, only the tests remain.

On top of that straight rebase, only two changes were necessary:

  1. #2866666: Add proper access handlers for view and form displays implemented the access control changes in a different (more refined) way than #5, I had to change the expected error message and the granted permission
  2. since #5 was created, a status field was added, so the expected config needed to be updated too

Other than that, this patch is identical to the one in #5 from more than 6 months ago — thanks @arshadcn!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Version: 8.4.x-dev » 8.5.x-dev

Actually, because #2866666: Add proper access handlers for view and form displays landed in 8.5 only, this also can be committed to 8.5 only.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 2843764-11.patch, failed testing. View results

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Reviewed & tested by the community

#11 perfect update! Fail in 8.4 as pointed in the #12 by Wim Leers.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 51f6344 and pushed to 8.5.x. Thanks!

  • catch committed 51f6344 on 8.5.x 
    Issue #2843764 by Wim Leers, arshadcn: EntityResource: Provide...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.