Missing bootstrap libraries include in theme info file [#2843640]

Missing bootstrap libraries include in theme info file, where not all declared libraries in VARTHEME_SUBTHEME.libraries.yml are included in VARTHEME_SUBTHEME.starterkit.yml.

Comment	File	Size	Author
#2	varbase-missing_bootstrap_libraries_include-2843640-2.patch	917 bytes	mqanneh

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

15 January 2017 at 14:25

mqanneh created an issue. See original summary.

Comment #2

mqanneh

he/him

English

Amman

CreditAttribution: mqanneh as a volunteer and at Vardot commented 15 January 2017 at 14:27

Assigned:	mqanneh	» Unassigned
Status:	Active	» Needs review

File	Size
varbase-missing_bootstrap_libraries_include-2843640-2.patch	917 bytes

Comment #3

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 15 January 2017 at 16:18

Good catch!!!

Not sure when it slipped.

Is it better to have it in the
VARTHEME_SUBTHEME.libraries.yml
or the
vartheme.libraries.yml

Comment #4

15 January 2017 at 16:19

RajabNatshah committed 0fe239c on 8.x-4.x authored by mqanneh

Issue #2843640 by mqanneh: Missing bootstrap libraries include in theme...

Comment #5

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 16 January 2017 at 14:59

Committed .. Thank you :)

We could have more study and testing for where to load the bootstrap and vartheme

We do have number of options.
1. Exclusive and exclude some of the base theme libraries
2. Double load, which I'm trying to avoid.
3. load on vartheme base theme only.
4. Only load in sub theme.

Which one do you think is better? or if we do have other options

Rewarded work on this fix :)