CommentFileSizeAuthor
#4 imageapi-this_t_should_be-2843310-4.patch10.88 KBSteven Jones
#2 ImageOptimize_2843310_1.patch9.63 KBnehakhadke
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke CreditAttribution: nehakhadke at Invezza Technologies commented
FileSize
ImageOptimize_2843310_1.patch9.63 KB

Status: Needs review » Needs work

The last submitted patch, 2: ImageOptimize_2843310_1.patch, failed testing.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Needs work » Needs review
FileSize
imageapi-this_t_should_be-2843310-4.patch10.88 KB

This at least needs to use the StringTranslationTrait

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented

I'm not sure any of the image api optimise plugins are being tested right now, so need to verify the changes there manually before merging this change in.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Parent issue: » #2826027: Drupal 8 2.0-beta1
Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Needs review » Fixed

Thanks for the issue and patch!

  • Steven Jones committed b8738b8 on 8.x-2.x 
    Issue #2843310 by nehakhadke, Steven Jones: $this->t() should be used...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.