Implement hook_uninstall to delete " composer_autoload_path " variable [#2842591]

Hi,
I hope to help.
A variable by the name " composer_autoload_path " is created when we submit the config form ("admin/config/development/composer_autoload"). The " composer_autoload_path " variable is not deleted on uninstalling the module.

Proposed Solution:-
1. Add a file named " composer_autoload.install "
2. Implement hook_uninstall() {} and delete the variable within it.

function composer_autoload_uninstall(){
  variable_del('composer_autoload_path');
}

Comment	File	Size	Author
#4	2842591-add_hook_uninstall_variable_del.patch	401 bytes	vishwac9
#2	add_hook_uninstall_variable_del.patch	428 bytes	vishwac9

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

11 January 2017 at 07:04

vishwac9 created an issue. See original summary.

Comment #2

vishwac9 CreditAttribution: vishwac9 as a volunteer and at InfoBeans Technologies Limited commented 11 January 2017 at 08:56

Status:	Active	» Needs review
Issue tags:		+Novice, +#novice

File	Size
add_hook_uninstall_variable_del.patch	428 bytes

Please find the patch

Comment #3

darrenwh CreditAttribution: darrenwh as a volunteer and at Investis Digital commented 19 January 2017 at 12:40

Status:	Needs review	» Needs work
Issue tags:		+mssprintjan17

+++ b/composer_autoload.install
@@ -0,0 +1,13 @@
\ No newline at end of file

File missing new line at end of file

+++ b/composer_autoload.install
@@ -0,0 +1,13 @@
+	variable_del('composer_autoload_path');

Indentation needs to be 2 spaces

Comment #4

vishwac9 CreditAttribution: vishwac9 as a volunteer and at InfoBeans Technologies Limited commented 12 January 2017 at 06:41

Status:

Needs work

» Needs review

File	Size
2842591-add_hook_uninstall_variable_del.patch	401 bytes

Thanks @darrenwh for pointing out the mistake, please find the updated patch

Comment #5

priyanka.attarde CreditAttribution: priyanka.attarde as a volunteer and at InfoBeans Technologies Limited commented 12 January 2017 at 12:21

Status:

Needs review

» Reviewed & tested by the community

Patch works well.

Comment #6

SwapS CreditAttribution: SwapS as a volunteer commented 16 January 2017 at 10:50

Status:

Reviewed & tested by the community

» Needs work

@vishwac9

Variable will get created in DB only when user saves configuration form for the module is submitted.
Just simple install & uninstall will result sql failure as Variable doesn't exist in DB.

Suggestion : Add install hook with default value

Cheers
SwapS

Comment #7

vishwac9 CreditAttribution: vishwac9 as a volunteer and at InfoBeans Technologies Limited commented 16 January 2017 at 14:05

@Swaps,

Thanks for the input, but i do not think so that would be a case. You can check for the variable_del document . It runs a db_delete query which checks for a condition by variable name, nor even the result of db_delete is checked. Even tried to install and quickly uninstall the module, havent seen any sql errors. If you do not have any other input please update the issue to RTBC, updated patches are surely welcomed :) .