We should provide a factory which returns configured Guzzle clients for interacting with the API.

CommentFileSizeAuthor
#5 provide_api_client-2842524-5.patch4.14 KBmglaman
#3 provide_api_client-2842524-3.patch4.12 KBmglaman
#2 provide_api_client-2842524-2.patch4.16 KBmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Active » Needs review
FileSize
provide_api_client-2842524-2.patch4.16 KB

Initial patch, needs to be tested up and all that.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for LivePerson, Inc commented
FileSize
provide_api_client-2842524-3.patch4.12 KB

Revised patch that is actually a factory.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for LivePerson, Inc commented
Status: Needs review » Needs work 
+++ b/commerce_avatax.services.yml
@@ -1,7 +1,10 @@
+    arguments: ['@config.factory', '@h']

http_client_factory

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for LivePerson, Inc commented
Status: Needs work » Needs review
FileSize
provide_api_client-2842524-5.patch4.14 KB

Fixed up patch

steveoliver’s picture

steveoliver CreditAttribution: steveoliver at Circatree commented
Status: Needs review » Fixed

Committed.

  • steveoliver committed 1589994 on 8.x-1.x 
    Issue #2842524: Fix docblock name of ClientFactory class.
steveoliver’s picture

steveoliver CreditAttribution: steveoliver at Circatree commented
Status: Fixed » Closed (fixed)