Problem/Motivation

#2823543: Make cron execution logging optional is a 8.3.x issue so its update function should be named accordingly.

Proposed resolution

Since 8.3.x does not have any kind of stable release, just rename the update function.

Remaining tasks

Review.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

CommentFileSizeAuthor
#4 interdiff.txt512 bytesamateescu
#4 2842480-4.patch713 bytesamateescu
#2 2842480.patch715 bytesamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu created an issue. See original summary.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Active » Needs review
FileSize
2842480.patch715 bytes

Also cleaned it up a little :)

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented 
+++ b/core/modules/system/system.install
@@ -1786,11 +1786,19 @@ function system_update_8202() {
+ * @addtogroup updates-8.3.0-beta1
...
+ * @} End of "addtogroup updates-8.3.0-beta1".

If we use beta1 in group, there will be a beta2, beta3, ..., betaN and we'll clutter un-necessary the file. So I think it's OK o name the group just updates-8.3.0-beta.

I see that it was used in this way for updates-8.0.0-beta

Otherwise looks ready for RTBC.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
FileSize
2842480-4.patch713 bytes
interdiff.txt512 bytes

Very good point, fixed :)

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status: Needs review » Reviewed & tested by the community

Perfect!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented 
+++ b/core/modules/system/system.install
@@ -1786,11 +1786,19 @@ function system_update_8202() {
+ * @addtogroup updates-8.3.0-beta
...
+ * @} End of "addtogroup updates-8.3.0-beta".

If you look at the other examples, we use updates-8.2.0, not updates-8.2.0-beta.

Beta etc was only relevant in the days before a 8.0 stable release I think?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 49e21af and pushed to 8.3.x. Thanks!

diff --git a/core/modules/system/system.install b/core/modules/system/system.install
index 45b0cd4..f1fcfba 100644
--- a/core/modules/system/system.install
+++ b/core/modules/system/system.install
@@ -1786,7 +1786,7 @@ function system_update_8202() {
  */
 
 /**
- * @addtogroup updates-8.3.0-beta
+ * @addtogroup updates-8.3.0
  * @{
  */
 
@@ -1800,5 +1800,5 @@ function system_update_8300() {
 }
 
 /**
- * @} End of "addtogroup updates-8.3.0-beta".
+ * @} End of "addtogroup updates-8.3.0".
  */

Fixed on commit.

  • alexpott committed 49e21af on 8.3.x 
    Issue #2842480 by amateescu: system_update_8203() is named incorrectly

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.