Problem/Motivation

We have added composer support for modules in other issues, now it is time to add it to distributions.

Proposed resolution

(For now) add composer support using composer manager.

Remaining tasks

  • Patch
  • Review
CommentFileSizeAuthor
#2 add_composer_support-2842430-2.patch1.64 KByanniboi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yanniboi created an issue. See original summary.

yanniboi’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
1.64 KB
yanniboi’s picture

The current patch unfortunately duplicates the modules built using drush make. So if a distribution provides a make file and a composer.json then it will build both.

In the case of opensocial (https://www.drupal.org/project/social) it provides both a make file and a composer.json in which case it downloads a load of module dependencies to webroot/profiles/social/modules/contrib as well as webroot/modules/. I think this isn't the worst because the composer downloaded modules take preference over those provided by the profile, so the install works and so should demoing the project on simplytest.me, but ideally if composer is used then the make file should be ignored.

patrickd’s picture

Status: Needs review » Fixed

Yeah, it's kind of a dirty hack but it's basically the same way it works right now when using project type module instead of distribution ¯\_(ツ)_/¯

works, deployed!

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.