Thanks for this fantastic module. I have it installed and working but do see a set of PHP notices in the site's recent log messages.

Steps to reproduce:

  1. New install of Drupal 8.2.5 with PHP version 5.5.24
  2. Image Annotator and Annotorious are the only "contributed" module/library
  3. Image Annotation enabled for the Article Content Type
  4. Annotations added to example Article node

The following messages show up in the "Recent log messages":

Notice: Undefined variable: userId in img_annotator_entity_view() (line 20 of /srv/bindings/XXX/code/modules/img_annotator/img_annotator.module) #0

CommentFileSizeAuthor
#3 patch-2842187.patch884 byteschaitanya17

Comments

EWB created an issue. See original summary.

chaitanya17’s picture

chaitanya17 commented
Assigned: Unassigned » chaitanya17
chaitanya17’s picture

chaitanya17 commented
Status: Active » Needs review
StatusFileSize
new patch-2842187.patch884 bytes

Hi EWB,

Please check attached working patch it resolves issue of "Recent log messages",

$nodeOwner was not in properly placed.

EWB’s picture

EWB commented
Status: Needs review » Reviewed & tested by the community

Hello Chaitanya17,

Thank you. I applied the patch and it appears to resolve the issue. Much appreciated.

Regards,
EWB

abhaysaraf’s picture

abhaysaraf commented

Thanks EWB and Chaitanya17 for raising the issue/concern and providing the solution.
In 8.x-1.1, I have added a new feature and fixed the raised bug. Please use 8.x-1.1.

chaitanya17’s picture

chaitanya17 commented

This should be applied as patch instead of manually changing in code base.

https://www.drupal.org/node/707484

abhaysaraf’s picture

abhaysaraf commented

Ok. Thanks for the reference. I will learn that and do it.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: chaitanya17 » Unassigned
Status: Reviewed & tested by the community » Closed (outdated)

Hello,

I am sorry but the patch changes had been fixed in other issues.