Rename ResourceConfig & ResourceManager and remove their interfaces

Blocked on #2841287: Remove ResourceManager::hasBundle(), ResourceManager::getEntityTypeManager(), ResourceConfig::getPath(), and rename ResourceConfig::getBundleId(), which is itself blocked on #2841056: Remove use of plugins.

This patch does exactly what is outlined in the IS.

#2841287: Remove ResourceManager::hasBundle(), ResourceManager::getEntityTypeManager(), ResourceConfig::getPath(), and rename ResourceConfig::getBundleId() is now already doing the second point in the IS. So, updating the IS and rerolling the patch.

I hadn't actually removed ResourceConfigInterface yet (point 1 in the IS). This does that.

I renamed ResourceConfig to ResourceType and ResourceManager to ResourceTypeRepository:

 rename src/{Configuration/ResourceConfig.php => ResourceType/ResourceType.php} (95%)
 rename src/{Configuration/ResourceManager.php => ResourceType/ResourceTypeRepository.php} (90%)
 rename tests/src/Kernel/{Configuration/ResourceManagerTest.php => ResourceType/ResourceTypeRepositoryTest.php} (72%)

Why "repository"? This is consistent with EntityRepository and BlockRepository.

Why "resource type"? Because this is not configuration, but just a mere value object representing a JSON API resource type.

#6 already renamed some occurrences of resource_manager and resourceManager to resource_type_repository and resourceTypeRepository. This updates the remainder.

Similar to #7: this renames all occurrences of $resource_config to $resource_type and occurrences of $this->resourceConfig to $this->resourceType.

I noticed that I'd failed to update CurrentContext::getResourceManager consistently. Turns out that that is actually completely unnecessary. Only EntityNormalizer uses it… and it should instead just get the resource manager (now resource type repository) injected. We shouldn't use the "current context" as a secondary container.

So, this removes that method altogether.

(This change could be moved to a separate issue that would block this issue if that's preferred.)

In one of the above patches, I cleaned up ResourceTypeRepository in a way that broke things. This fixes it.

Rename CurrentContext::getResourceConfig() to CurrentContext::getResourceType().

Rename RelationShipItem::getTargetResourceConfig() to RelationShipItem::getTargetResourceType().

Yep, I was still working on that at the end of my day. I will finish this tomorrow :)

If that's the only major remark you have, then that's awesome :D But I suspect you'll have more feedback :)

Finally, made all comments consistent.

Next up: #13 + #14. Also, #2841056: Remove use of plugins landed, so just PP-1 now.

Also, while working on #15, I also wanted to do this:

@@ -18,14 +18,7 @@ use Symfony\Component\HttpFoundation\RequestStack;
 class CurrentContext implements CurrentContextInterface {
 
   /**
-   * The resource type repository.
-   *
-   * @var \Drupal\jsonapi\ResourceType\ResourceTypeRepository
-   */
-  protected $resourceTypeRepository;
-
-  /**
-   * The current resource config.
+   * The current JSON API resource type.
    *
    * @var \Drupal\jsonapi\ResourceType\ResourceType
    */
@@ -56,23 +49,19 @@ class CurrentContext implements CurrentContextInterface {
    *   The current route match.
    */
   public function __construct(ResourceTypeRepository $resource_type_repository, RequestStack $request_stack, RouteMatchInterface $route_match) {
-    $this->resourceTypeRepository = $resource_type_repository;
     $this->requestStack = $request_stack;
     $this->routeMatch = $route_match;
+
+    $route = $this->routeMatch->getRouteObject();
+    $entity_type_id = $route->getRequirement('_entity_type');
+    $bundle = $route->getRequirement('_bundle');
+    $this->resourceType = $this->resourceTypeRepository->get($entity_type_id, $bundle);
   }
 
   /**
    * {@inheritdoc}
    */
   public function getResourceType() {
-    if (!isset($this->resourceType)) {
-      $route = $this->routeMatch->getRouteObject();
-      $entity_type_id = $route->getRequirement('_entity_type');
-      $bundle = $route->getRequirement('_bundle');
-      $this->resourceType = $this->resourceTypeRepository
-        ->get($entity_type_id, $bundle);
-    }
-
     return $this->resourceType;
   }

i.e. I wanted to remove that protected $resourceTypeRepository, because it's not actually used — it can just be used in the constructor and then call it a day. Unfortunately, there's a bug in core that gets in the way: #2841542: \Drupal\serialization\EventSubscriber\UserRouteAlterSubscriber has serializer service injected, but doesn't use it — also makes route rebuilding more expensive.

(Although, to be fair, the real problem here is that JSON API's normalizers depend on the current request/route match — the Symfony serialization system is designed to be independent of requests. Improving that is for another issue.)

This then does #13 + #14.

And now this is ready!

This is blocking #2841591: Remove EntityResource, move its logic into RequestHandler, clean up routes.

2. That's already in the base class :) Not my idea, it was already there!

3+4. There are quite a few unused use statements in various places in the codebase, so I didn't play too close attention. You can remove them on commit, or we can just fix it in a big "coding standards cleanup" patch that we will need to do anyway before this can get into core. :)

1+5. :)

6. Hah, nice catch!

I take you're also convinced of the new names I'm suggesting here?

First, rebasing, because #2840948: Remove interfaces of JSON API-specific normalizers was committed too, which caused this to no longer apply.

(This is equivalent to the patch in #17.)

Fixed all points (3+4+6) in #23.

LOL, a single typo was causing all those fails AFAICT! Didn't notice locally (everything passes locally), because I'm on a case-insensitive file system!

WOOOOOT!