The current Math plugin only takes in a numeric value. It would be useful to have another math plugin (Math field) that allows users to select a field to do the operation with. See screenshot. (patch to come shortly).

CommentFileSizeAuthor
#5 feeds_tamper-math_fields_support-2841168-5.patch7.65 KBvictoriachan
#4 feeds_tamper-math_fields_support-2841168-4.patch7.7 KBvictoriachan
#2 feeds_tamper-math_fields_support-2841168-2.patch7.7 KBvictoriachan
screenshot.png49.55 KBvictoriachan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

victoriachan created an issue. See original summary.

victoriachan’s picture

victoriachan CreditAttribution: victoriachan at Torchbox commented
Status: Active » Needs review
FileSize
feeds_tamper-math_fields_support-2841168-2.patch7.7 KB

Patch with new plugin + test.

Status: Needs review » Needs work

The last submitted patch, 2: feeds_tamper-math_fields_support-2841168-2.patch, failed testing.

victoriachan’s picture

victoriachan CreditAttribution: victoriachan at Torchbox commented
FileSize
feeds_tamper-math_fields_support-2841168-4.patch7.7 KB

Sorry, a tiny omission regarding stray validation. Have corrected it now. New patch attached. Note that the test is failing because of https://www.drupal.org/node/2835936

victoriachan’s picture

victoriachan CreditAttribution: victoriachan at Torchbox commented
FileSize
feeds_tamper-math_fields_support-2841168-5.patch7.65 KB

Sorry! Wrong patch. Correct one attached now.

adigunsherif’s picture

adigunsherif CreditAttribution: adigunsherif commented

Patch #5 works perfectly! Thanks

guitmann’s picture

guitmann CreditAttribution: guitmann as a volunteer and commented

its not work:(
Notice: Undefined index: id in function feeds_tamper_math_field_callback() (line 90 in file /sites/all/modules/feeds_tamper/plugins/math_field.inc).