Hello,
I'm sending less than the minimum amount of emails required to need any credit so my credit balance is $0.00
On every admin page I get a waring about low credit. The settings page if I set the credit threshold to 0 then I won't get any messages. It is at 0 and I still get the warnings.
Looking at the code, InitSubscriber::onEvent() triggers this warning. The check is if the credit is less than or equal to the threshold. Since both the credit and threshold are 0 the warning is shown.
I suggest specifically checking that the threshold is empty as the description on the setting says that setting to 0 will prevent the warning.
Patch to follow.
Comment | File | Size | Author |
---|---|---|---|
#2 | elastic_email-2841074-2.patch | 800 bytes | johnennew |
Comments
Comment #2
johnennew CreditAttribution: johnennew at Deeson commentedPatch checks for the empty threshold value before showing warning.
Comment #3
mike.davis CreditAttribution: mike.davis at Deeson commentedThanks @ceng for this patch this looks like it has fixed this issue so I will commit this.
I think that this warning will be changing slightly in 8.x-3.x as this will be using the new API provided by Elastic Email and the way that they are now dealing with volume of emails that you can send in a month, this warning only really becomes relevant if you are sending more than 25,000 emails a month :)
Comment #5
mike.davis CreditAttribution: mike.davis at Deeson commentedThis has been committed now, thanks