The "Submit" button text and other strings configurable in the Better Exposed Filter settings in Views are not translatable. The Submit button text is translatable when using the Basic exposed filter provided by Views, but once I switch the view to use Better Exposed Filters I can no longer translate it.

The attached patch fixes this issue.

If there are new labels/fields added to the settings form, then further configuration changes may be required, but all the default ones work and I don't think there are others? Perhaps the rewriting of checkbox/radio option labels but not sure how to approach that one yet.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stella created an issue. See original summary.

nicrodgers’s picture

Status: Needs review » Reviewed & tested by the community

Applies successfully and makes all the default options translatable. Nice one!

  • mikeker committed d1f5c69 on 8.x-3.x authored by stella
    Issue #2841054 by stella: Submit button text not translatable
    
mikeker’s picture

Status: Reviewed & tested by the community » Fixed

Thanks @stella and @nicrodgers! Committed and pushed to the 8.x-3.x branch.

re: translation of rewrite options: That's a much harder issue to deal with because of the way the settings are stored (hate it when decisions made 8 years ago come back to haunt you...). I've been working on that as part of #2790567: Missing config schema but haven't had any free time recently. The main issue is that dynamically named settings (eg: the settings for a given filter) and fixed settings (eg: the label for secondary options) are stored at the same depth in the settings array meaning we can't use wildcards in the schema.

If anyone has any suggestions, I'm all ears!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.