\Drupal\jsonapi\Encoder\JsonEncoder should extend the serialization module's JsonEncoder, not Symfony's [#2840967]

Why? Because #2813755: JSON responses encoded inconsistently: make them all RFC4627-compliant.

Comment	File	Size	Author
#2	jsonapi_encoder_serialization-2840967-2.patch	1.18 KB	Wim Leers
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 176 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

4 January 2017 at 10:45

Wim Leers created an issue. See original summary.

Comment #2

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 4 January 2017 at 10:57

Status:	Active	» Needs review
Parent issue:		» #2829327: Review JSON API module for core-readiness

File	Size
jsonapi_encoder_serialization-2840967-2.patch	1.18 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 176 pass

Comment #3

hampercm CreditAttribution: hampercm at Acquia commented 4 January 2017 at 18:42

Status:

Needs review

» Reviewed & tested by the community

Looks good!

Comment #4

5 January 2017 at 06:45

e0ipso committed 5d87587 on 8.x-1.x authored by Wim Leers

fix(Serialization) Extend from serialization's JsonEncoder, not Symfony'...

Comment #5

e0ipso

Catalan

Can Picafort

CreditAttribution: e0ipso as a volunteer and at Lullabot commented 5 January 2017 at 06:46

Status:

Reviewed & tested by the community

» Fixed

Comment #6

19 January 2017 at 06:54

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

\Drupal\jsonapi\Encoder\JsonEncoder should extend the serialization module's JsonEncoder, not Symfony's

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Parent issue

Related issues

Thank you to these Drupal contributors

News items

Our community

Documentation

Drupal code base

Governance of community