Azure Datamarket has changed

Experincing the same issue. To elaborate: In the Azure Portal, go to 'All resources' somewhere in this list you can click on your Cognitive Services account for the current project. Under the 'resource management' vertical tab you can find 'keys' section.
They you can find three values:
- Account name
- KEY 1
- KEY 2

Haven't found a way to get these working yet. Which I think makes sense probably, I can imagine there is a completely new auth system in place now. Probably API changed too.

Datamarket/translator will stop working end of april. See https://translatorbusiness.uservoice.com/knowledgebase/articles/1078534-...
This module will probably stop functioning completely at that point, therefore setting priority to critical.
According to that page:

To begin using the Microsoft Translator subscription from Azure, you will need to replace the app authentication using your Microsoft Data Market Client ID and Client Secret with your new Azure key. The single Azure key is used to request an Azure token for the Microsoft Translator service.

There is a replacement in Azure. We might just need to updated some endpoints and use a single key, instead of the combo key/secret. Anyone up to rolling a patch. See https://cognitive.uservoice.com/knowledgebase/articles/1128340-announcem...

New endpoint: https://api.cognitive.microsoft.com/sts/v1.0/issueToken

I've patched the module to use the new endpoint and API key.

Do we need an update path? Me thinks yes.

Or maybe not... since the old api keys are going to be non-functional. Moving to NR for now.

I'm receiving the error message "The "Client ID" or "Client secret" is not valid." Please let me know if the patch (tmgmt_microsoft-azure-congnitive-api-update-2840876-6.patch) is included with 7.x-1.x-dev or 7.x-1.0-alpha2 or if it has to be applied. Thank you very much.

Please apply ASAP

Needs an update path. Marking as NW. Or a @TODO and an opened issue to add an update path.

What update path? They are completely different systems with different keys.

Agreed that an upgrade path is not possible.

I worked a bit on this to fix/update tests and also quite a bit of cleanup, the code was getting pretty strange with 3 different api methods implemented but everything except the new API is no longer working, so there's no point in trying to support them still.

A commit without status change?

Does this need 8.x care?

Looks like my comment got lost.

This gets it working in d8, I haven't had time to adjust the tests yet.

Hello,

I wanted to test tmgmt with Microsoft, so I applied patch from comment 17. It fixed the issue.

Thanks.

patched the #17 patch

but

Client error: `GET http://api.microsofttranslator.com/v2/Http.svc/GetLanguagesForTranslate` resulted in a `400 Bad Request` response:
Argument Exception

Method: GetLanguagesForTranslate()

Parameter:

Message: The API ty (truncated...)

Checkout the back-port of the #17 patch for he 7.x version #2962022: Microsoft data market is closed, Moving to Microsoft Azure CognitiveServices

Let's see if this fixes the tests.

Hmm, this seems to use v2, which is already deprecated. If we are going to land this, wouldn't it be better to use V3? https://docs.microsoft.com/en-us/azure/cognitive-services/translator/ref...

Here's a sample example in PHP:
https://github.com/MicrosoftTranslator/Text-Translation-API-V3-PHP/blob/...

There's still some test failures, but less.

Manual testing, this worked. Not to get all the automated tests working.

Tests passed on local.

Fix up a few more CS things. Tried to reproduce the bugs, but not sure I was able to. I tested locally against 8.5 and 8.6, just to be sure it wasn't a core thing.

Some debugging added to figure out what is displayed on the testbot.

OK, let's forget simpletest and try a proper functional test. This one also passes on local, but so did the simpletest. Fingers crossed.

For reviewers, the test is basically a straight port to functional w/ as little changed as possible.

Code standards + possibly we are facing concurrency? Let's try that.

drupal_static? Let's see.

I think tests are currently failing. Let's see.

I give up. Tests pass just fine on local. I was hoping I could get this to pass tests, but I need to move on. I'll just keep using the patch.

Thanks for the patch and your perseverance :-)

Why are we testing PHP 5.5, it's deprecated. Let's see what 5.6 and 7.2 make of it.

Cannot get languages from the translator: Server error: `GET http://php-apache-jenkins-drupal8-contrib-patches-29014/subdirectory/tmg...` resulted in a `500 Internal Server Error` response: 500 Internal Server Error < (truncated...)
The "Azure API Key" is not valid.

Have a look at the test output on https://dispatcher.drupalci.org/job/drupal8_contrib_patches/29014/artifa...

More details hopefully with these test additions.

You're getting there!

Different approach to things. Big interdiff.

Cleaned up things I spotted.

For some reason, the following returns empty string on the testbot. Any suggestions, would be much appreciated.

  public function getLanguages(Request $request) {
    $query = $request->query;
    if (!$query->has('api-version')) {
      return new Response('Bad request - missing: api-version', 400);
    }
    $json['translation']['de'] = [
      'name' => 'German',
      'nativeName' => 'German',
      'dir' => 'ltr',
    ];
    $json['translation']['en'] = [
      'name' => 'English',
      'nativeName' => 'English',
      'dir' => 'ltr',
    ];
    $json['translation']['es'] = [
      'name' => 'Spanish',
      'nativeName' => 'Espanol',
      'dir' => 'ltr',
    ];
    return new JsonResponse($json);
  }

    $languages = [
      'route' => 'tmgmt_microsoft_test.languages',
      'verb' => 'GET',
      'key' => $good_key,
      'query' => [
        'scope' => 'translation',
        'api-version' => '3.0',
      ],
    ];
    $response = $this->assertHttpRequest('languages', $languages);
    $json = json_decode((string) $response->getBody()->getContents(), TRUE);

The most simple test possible.

Too slimmed down.

So, after consulting with mixologic and berdir in slack, we figured out it was an issue with how run-tests.sh does things vs phpunit. Its something to do with `BROWSERTEST_OUTPUT_DIRECTORY` being set in run-tests.sh as an env var when the test is executed.

is the patch using $response->getBody()->getContent() or so
don't do that
use (string) $response->getBody()
the response body has an internal pointer

Ignore all the chatter in between 68 and 81. It was just trying to pin down what the issue was. This should now pass.

Yeah. Tests pass green.

Whoohoo!!! @heddn, you win a gold medal for this one, heck I'd give you a diamond one if I could :-)

Big thanks to mixologic and berdir as well.

Thanks for the patch! I've tweaked it slightly to change the max supported characters to 5000 as per the current API specification.

3ks you guys

the patch applied,

And need help to make it work when a node body exceeds 5000 characters

I think #84 failed because TMGMT was broken on 8.7 at the time. Setting back to needs review.

Even with patch #84, we couldn't connect the provider. Apparently we need to use a regional service URL: https://docs.microsoft.com/azure/cognitive-services/translator/reference....

Everyone, thanks for your contributions.