I have a small suggestion for improvement regarding HTML mailing (webform_mail_alter() function).

Often developers will name some additional custom modules as webform_something. Sometimes those custom supplementary modules will send emails. And then the current implementation of webform_mail_alter() will hook in and will be expecting $message['params']['html'] to be available. This param is available when webform module sends its mails, but other custom/sub-modules may not have such parameter within their mails.

So I'd also check whether $message['params']['html'] is set to play nicer with submodules.

CommentFileSizeAuthor
#2 2840805-php-notice-mail-alter-2.patch578 bytesbucefal91
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bucefal91 created an issue. See original summary.

bucefal91’s picture

bucefal91 CreditAttribution: bucefal91 at Websolutions Agency commented
Status: Active » Needs review
FileSize
2840805-php-notice-mail-alter-2.patch578 bytes

I attach a patch. Hehe, it must be an easy guess that I actually have some such custom module :) I've tested it with my custom module and the PHP notice is gone.

  • jrockowitz committed 86cf517 on 8.x-5.x authored by bucefal91 
    Issue #2840805 by bucefal91: Undefined index: html in webform_mail_alter...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.