We removed commerce_tax for beta1 because the data model was too slow and there was no other logic.
Taxes are our biggest remaining RC1 blocker, so time to get it (re)done.

Tracking only the data model issues for now cause the calculation logic still needs work.

Comments

bojanz created an issue. See original summary.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

Commit that removed the old code: https://github.com/drupalcommerce/commerce/commit/d37fdd9c93bac2db5e08ee...

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Title: [meta] Re-implement the tax module » Re-implement the tax module
Assigned: Unassigned » bojanz

No longer a meta. And in-progress.

Folded #2841016: Create the tax data model back into this issue, see the discussion there for historical purposes.
Did the same with #2840688: Add a taxable type setting to product variation types.

The basic architecture will be the TaxType plugin + config entity pair. This allows us to have an Eu plugin that hardcodes the EU tax rates, avoiding the "let's load over 50 rates at once" performance problem unique to the EU. It also allows us to have a "Custom" plugin for defining own tax zones/rates/amounts. Tax type plugins can be local (eu, custom) or remote (avatax, taxamo, etc).

Once this commit lands we can move on to implementing tax overrides, which will be rules-like entities that embed conditions for a specific tax type ("Choose Reduced if product category is X").

  • bojanz committed d975c7e on 8.x-2.x 
    Issue #2840683: Re-implement the tax module.
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Active » Fixed

Merged. Next stop: #2872190: Create tax rate resolvers.

Note that taxes are not showing up for me on the cart locally right now, need to debug and write additional tests.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.