Coding Standards [#2840654]

Comment	File	Size	Author
#10	Screen Shot 2017-04-13 at 3.33.47 PM.png	53.4 KB	krina.addweb
#9	2840654-9.patch	7.92 KB	Shashwat Purav
#7	Screen Shot 2017-04-13 at 11.39.48 AM.png	67.01 KB	krina.addweb
#2	coding_standards-2840654-2.patch	7.41 KB	gmaltoni

Comment #1

3 January 2017 at 14:06

gmaltoni created an issue. See original summary.

Log in or register to post comments

Comment #2

gmaltoni CreditAttribution: gmaltoni at CI&T commented 3 January 2017 at 14:09

File	Size
coding_standards-2840654-2.patch	7.41 KB

Patch with fixes.

Log in or register to post comments

Comment #3

gmaltoni CreditAttribution: gmaltoni at CI&T commented 6 January 2017 at 18:20

Assigned:

gmaltoni

» Unassigned

Log in or register to post comments

Comment #4

cebasqueira CreditAttribution: cebasqueira at CI&T commented 16 January 2017 at 18:38

Status:

Needs review

» Reviewed & tested by the community

+RTBC

Log in or register to post comments

Comment #5

mikran CreditAttribution: mikran as a volunteer commented 24 February 2017 at 06:24

-  // parents keeps track of all the parents of selected nodes so subsequent
-  // requests can be made.
+  // Parents keeps track of all the parents of selected nodes so subsequent requests can be made.

I don't think this change is correct. Comments should respect the 80 char line limit.

Log in or register to post comments

Comment #6

mikran CreditAttribution: mikran as a volunteer commented 24 February 2017 at 06:25

Status:

Reviewed & tested by the community

» Needs work

Log in or register to post comments

Comment #7

krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented 13 April 2017 at 06:15

File	Size
Screen Shot 2017-04-13 at 11.39.48 AM.png	67.01 KB

@gmaltoni, I checked your patch using coder module & it shows 1 warning in it. I've attached the screenshot for it please review & let me know your views on it.