[D7] Link Field Formatter

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxmandarmbhagwat782294...

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I tested this modules for couple of scenarios and it works fine for me and didn't find an issue.
No coding standard issue found.

1: All user facing text should be Pass through t()

Example "Download" text in following code

  if ($user->uid == $file->uid && user_access('download own audio files')) {
    $output .= '<div class="audio-download"><b>Download:</b>' . theme('link', array('path' => $audiofile)) . '</div>';
  }
  elseif (user_access('download all audio files')) {
    $output .= '<div class="audio-download"><b>Download:</b>' . theme('link', array('path' => $audiofile)) . '</div>';
  }

Some more examples :

  if ($video_style == 'vzaar') {
    $output = '<video width="' . $width . '" height="' . $height . '" ' . implode(' ', $attributes) . '>
      <source src="' . $videofile . '/video">Your browser does not support the video tag.</video>';
  }
  else {
    $output = '<video width="' . $width . '" height="' . $height . '" ' . implode(' ', $attributes) . '>
      <source src="' . $videofile . '" type="video/' . $video_style . '">Your browser does not support the video tag.</video>';
  }

2: Please set the default branch

The .module and .inc file are full with undefined variables, including but not limited to the following:

Play audio with download link:
Notice: Undefined variable: audio_style in link_field_formatter_field_formatter_view() (line 352 of /usr/share/nginx/html/drupal7/sites/all/modules/contrib/link_field_formatter/link_field_formatter.module).
Notice: Undefined variable: audio_style in link_field_formatter_field_formatter_view() (line 357 of /usr/share/nginx/html/drupal7/sites/all/modules/contrib/link_field_formatter/link_field_formatter.module).

Play audio without download link:
Notice: Undefined variable: audio_style in link_field_formatter_field_formatter_view() (line 368 of /usr/share/nginx/html/drupal7/sites/all/modules/contrib/link_field_formatter/link_field_formatter.module).
Notice: Undefined variable: audio_style in link_field_formatter_field_formatter_view() (line 373 of /usr/share/nginx/html/drupal7/sites/all/modules/contrib/link_field_formatter/link_field_formatter.module).

When using Video formatter:
Notice: Undefined variable: video_style in link_field_formatter_field_formatter_view() (line 423 of /usr/share/nginx/html/drupal7/sites/all/modules/contrib/link_field_formatter/link_field_formatter.module).
Notice: Undefined variable: attributes in link_field_formatter_field_formatter_view() (line 424 of /usr/share/nginx/html/drupal7/sites/all/modules/contrib/link_field_formatter/link_field_formatter.module).
Notice: Undefined variable: attributes in theme_link_field_formatter_video() (line 203 of /usr/share/nginx/html/drupal7/sites/all/modules/contrib/link_field_formatter/link_field_formatter.inc).
Warning: implode(): Invalid arguments passed in theme_link_field_formatter_video() (line 203 of /usr/share/nginx/html/drupal7/sites/all/modules/contrib/link_field_formatter/link_field_formatter.inc).

The audio player seems to be throwing fatal errors on the link rendering:

Audio (Player):
Recoverable fatal error: Argument 1 passed to drupal_attributes() must be of the type array, null given, called in /usr/share/nginx/html/drupal7/includes/theme.inc on line 1739 and defined in drupal_attributes() (line 2435 of /usr/share/nginx/html/drupal7/includes/common.inc).

Audio (Embed):
Recoverable fatal error: Argument 1 passed to drupal_attributes() must be of the type array, null given, called in /usr/share/nginx/html/drupal7/includes/theme.inc on line 1739 and defined in drupal_attributes() (line 2435 of /usr/share/nginx/html/drupal7/includes/common.inc).

I have tested local and with pareview.sh. The things i have found are :

FILE: ...README.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 83 | WARNING | Line exceeds 80 characters; contains 83 characters
----------------------------------------------------------------------

Time: 362ms; Memory: 4Mb

FILE: ...link_field_formatter.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 376 | WARNING | Unused variable $weight.
----------------------------------------------------------------------

Time: 217ms; Memory: 5.25Mb

FILE: ...link_field_formatter.inc
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 12 | WARNING | Unused global variable $user.
 35 | WARNING | Unused global variable $user.
----------------------------------------------------------------------

Time: 117ms; Memory: 3.25Mb

Nice comments, really helped work with it.
I didn't find anything serious.

@Drupal8: looks like you forgot to change the status. Anything else that you found other than the minor coding standard issues or should this be set to RTBC?

No serious issue.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2858820

Project 2: https://www.drupal.org/node/2840573

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.