Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
From a comment by @eojthebrave:
I wonder if we should change the order of these links while we're at it. It seems like we could do a better job of ordering things based on order of complexity, and/or order that people are likely to want to learn these things.
Right now the order with this patch is:
- Simple Form
- Input Demo
- Form State Example
- Container Demo
- Vertical Tab Demo
- Ajax Demo
- Modal Example
- Build Demo
- Ajax Add More
Proposed resolution
I think this might be a better order overall:
- Simple Form
- Input Demo
- Build Demo
- Container Demo
- Form State Example
- Vertical Tab Demo
- Ajax Demo
- Ajax Add More
- Modal Example
Additionally, looking at this list, it seems like "Form State Example" isn't a great name. And something like "States API Example" might be better. Based on the title alone I assumed it was going to be about $form_state, and not #state => array() stuff.
At a minimum this new link should be grouped next to the existing AJAX Demo I think.
Remaining tasks
User interface changes
Minor.
API changes
None.
Data model changes
None.
Follow-up to #2831294: Page controller is missing a menu link
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 2840529-11-fapi_example-reorder.patch | 5.72 KB | navneet0693 |
| |||
| #5 | Form API Examples.png | 77.57 KB | navneet0693 |
| #5 | interdiff-5.txt | 2.24 KB | navneet0693 |
| #5 | 2840529-5-fapi_example-reorder.patch | 5.36 KB | navneet0693 |
| |||
| #4 | 2840529-2-fapi_example-reorder.patch | 3.12 KB | eojthebrave |
| |||
Comments
Comment #3
Torenware CreditAttribution: Torenware as a volunteer commentedComment #4
eojthebraveThis re-orders the list both in the docblock in fapi_example.module and in \Drupal\fapi_example\Controller\Page::description()
Comment #5
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commentedUploading a patch that makes the ordering of links in block menu and page similar. Refer to screenshot for observation of issue.
Comment #6
andypostLGTM
Related needs update for weight also and provides "configure" link for fapi module, that could be done here as well
Comment #7
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commented@andypost Right, I will re-roll the patch once #2793383: A multistep form example is missing in fapi_example this one is fixed.
Comment #8
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commentedI am marking this as postponed.
Comment #9
Torenware CreditAttribution: Torenware as a volunteer commented#2793383: A multistep form example is missing in fapi_example was fixed a few days ago. Laissez les bons temps rouler!!
Comment #10
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commentedIt will need a re-roll + some new additions.
Comment #11
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commentedRerolled and added MultiStep after Simple Form.
Comment #13
Mile23The patch in #11 looks good.
I changed it so the route titles match the menu link titles which also match the link names on the page.
In the process I changed the names of some things, which might not be 100% for everyone, so please file a follow-up if I made a mistake.
Thanks, folks.