Follow-up to #2061377: [drupalImage] Optionally apply image style to images uploaded in CKEditor 5.
Problem/Motivation
In the parent issue it was decided (#222-27) that removing some no-longer needed attibutes during FilterImageStyle processing should be done consistently in other text filters affecting image markup, such as EditorFileReference
.
Proposed resolution
Remove attributes data-entity-type
, data-entity-uuid
, and data-image-style
from image markup in FilterImageStyle::process()
and EditorFileReference::process()
.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#3 | 2840513-2.diff | 1.73 KB | ifreeman |
#2 | 2840513-1.diff | 801 bytes | ifreeman |
Comments
Comment #2
ifreeman CreditAttribution: ifreeman commentedPatch applicable to #2061377-237: [drupalImage] Optionally apply image style to images uploaded in CKEditor 5 .
Comment #3
ifreeman CreditAttribution: ifreeman commentedOops, missed a hunk.
Patch applicable to #2061377-237: [drupalImage] Optionally apply image style to images uploaded in CKEditor 5.
Comment #12
alexpottWe'll need to add a change record if we do this as it is possible people have written code that depends on this being in the final markup. Is it really worth doing this?