Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Before the release of 8.2 , in core NodeInterface extended RevisionlogInterface (thus having getRevisionLogMessage() method ). Currently throughout the module there exists unnecessary check that revision is instance of NodeInterface. So, remove it and make small refactoring according to it.
Proposed resolution
Fix to RevisionLogInterface
Remaining tasks
User interface changes
No changes from our side.
API changes
Fix wrongly Interface use.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | revision_log_interface-2840174-4.patch | 2.74 KB | ModernMantra |
| #2 | revisionloginterface-2840174-2.patch | 3 KB | ModernMantra |
Comments
Comment #2
ModernMantra CreditAttribution: ModernMantra at MD Systems GmbH for MD Systems GmbH commentedMade some exploration together with @miro_dietiker. So we found that
Nodehas implementation of getRevisionLogMessage(), thus it is removed unnecessary check that$revisionis intance ofNodeInterface. Furthermore, discovered some 'weird' logic inDiffEntityComparison::getRevisionDescription()(made there some refactoring that it looks more 'beautiful')Comment #4
ModernMantra CreditAttribution: ModernMantra at MD Systems GmbH for MD Systems GmbH commentedRecent commits caused that patch does not apply to DiffLayoutBase
Comment #5
ModernMantra CreditAttribution: ModernMantra at MD Systems GmbH for MD Systems GmbH commentedComment #6
miro_dietikerYeah, thx, committed. Much complexity gone. :-)