Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Rend...
On protected static function FormattableMarkup::placeholderFormat, there are a couple issues with the %variable placeholders section.
The example code has the following line:
$arguments = ['output_text' => 'text output here.'];
Should be this (missing %):
$arguments = ['%output_text' => 'text output here.'];
The html example looks like this:
<em class="placeholder">text output here.em>
Should look like this:
<em class="placeholder">text output here.</em>
Comment | File | Size | Author |
---|---|---|---|
#2 | 2839951-2.patch | 658 bytes | badjava |
Comments
Comment #2
badjava CreditAttribution: badjava at Metasun for Pfizer, Inc. commentedLooks like the html example was fixed already but the placeholder was not. Here is a patch for the first issue.
Comment #3
chiranjeeb2410 CreditAttribution: chiranjeeb2410 commentedComment #4
chiranjeeb2410 CreditAttribution: chiranjeeb2410 commentedAdded the missing " % " to the argument placeholder.
Comment #5
chiranjeeb2410 CreditAttribution: chiranjeeb2410 commentedComment #7
badjava CreditAttribution: badjava at Metasun for Pfizer, Inc. commented@chiranjeeb2410 Thanks for setting to needs review but the patch I already submitted is fine. I am removing patch #4 as it is incorrect and doesn't add anything new.
Comment #8
JayKandari#2 Looks good.
Patch file has the updated code as described in Issue Description.
Changing status to RTBC.
Comment #9
chiranjeeb2410 CreditAttribution: chiranjeeb2410 commented#4 was unnecessary though. Anyways #2 works just fine. Closing the issue as of now.
Comment #10
chiranjeeb2410 CreditAttribution: chiranjeeb2410 commentedComment #11
cilefen CreditAttribution: cilefen as a volunteer commented@chiranjeeb2410 Code must be committed to the codebase in order for this issue to be fixed.
Comment #12
alexpottCommitted and pushed c250a53 to 8.3.x and b093322 to 8.2.x. Thanks!