Overriding the service does not work on a site instal [#2839452]

I've added the service as documented in the readme in my services.yml file

services:
  config.storage.sync:
    class: Drupal\config_split\Config\StorageWrapper
    factory: config_split.manager:getDefaultStorageWrapper

This works perfectly on a working site.

I then tried to install my site from scratch (we use an install profile via drush site-install) and it failed because the service is not known (yet).
How can I fix this? Am I doing something wrong? Should it be working?

Comment	File	Size	Author
#2	2839452-2.patch	978 bytes	bircher
#2	8.x-1.x: PHP 7 & MySQL 5.5, D8.3 17 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

27 December 2016 at 10:06

weseze created an issue. See original summary.

Comment #2

bircher

🇨🇿

CreditAttribution: bircher as a volunteer and at Nuvole for World Food Programme commented 22 January 2017 at 22:27

File	Size
2839452-2.patch	978 bytes
8.x-1.x: PHP 7 & MySQL 5.5, D8.3 17 pass

Try the attached patch.
It replaces the service only when the module is available. When you install the site the class is not available to Drupal and when you switch out the definition of the service in services.yml it will be broken until config_split is enabled.

I will commit it once I tested that console works with it. Console had an issue that expected it to be a FileStorage instead of a StorageInterface.