Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The Acquia connector should follow the latest change in search_api_solr:
#2835770: Cannot subscribe to Solarium events
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | interdiff-2838963-8-10.txt | 2.81 KB | Dane Powell |
| #10 | acquia_connector-2838963-10.patch | 2.52 KB | Dane Powell |
| |||
| #2 | acquia_connector-swap_event_subscriber-2838963-2.patch | 5.75 KB | ruloweb |
Comments
Comment #2
ruloweb CreditAttribution: ruloweb at Velir commentedHi, attached is a patch that swap to the Drupal eventDispatcher. SearchSubscriber class requires to be updated a little bit the as well.
It only applies to last dev, not to 8.x-1.12, because of the few last commits.
Comment #3
ruloweb CreditAttribution: ruloweb at Anexus, Velir commentedThe last patch was missing the event service definition, anyway it has a few bugs, for example the events in SearchSubscription class should only be called with the current search is using the Acquia connector.
Attached is a new version, is a different (and better I think) approach so I doesn't make sense to upload a interdiff.
Comment #4
dorficus CreditAttribution: dorficus at Genuine commentedThis patch is still referenced in the Acquia docs. Is it still needed for 1.16.0 to use Solr Devel? If so, it does not apply cleanly and will need a reroll.
Comment #5
dorficus CreditAttribution: dorficus at Genuine commentedRerolled to work with 1.16.0
Comment #6
dorficus CreditAttribution: dorficus at Genuine commentedOh wow, it's way too early for me and it's Friday. I made a mistake and tested the wrong patch against 1.16.0 and saw issues. This "reroll" is exactly the same as #3.
Don't mind me...
Comment #7
dorficus CreditAttribution: dorficus at Genuine commentedThis patch worked. I tested it on an Acquia dev environment and I was able to get Solr Devel working to debug my queries on the Dev server. Marking RTBC.
Comment #8
kybermanHi James, the patch can't be applied against the current code, unfortunately.
Here is a reroll for current dev that is applicable also for 1.18, but not tested yet.
Comment #9
Dane Powell CreditAttribution: Dane Powell at Acquia commentedThe test failures in #8 need to be resolved. It looks like the search subscriber needs to implement PluginInterface?
Comment #10
Dane Powell CreditAttribution: Dane Powell at Acquia commentedThe attached patch should pass tests. Can someone please test that it fixes the original issue for all of this, which I believe is compatibility with Solr Devel?
#8 wasn't working because it was trying to set a protected property on the parent plugin. So when it tried to register that plugin later on, it was passing a null reference instead of the SearchSubscriber instance. I went back to the old way of creating that plugin. I don't see a clean way to handle this with service injection given that the create method is static, and anyway that's refactoring not exactly related to this patch.
Comment #12
Dane Powell CreditAttribution: Dane Powell at Acquia commented