Problem/Motivation

EntityResourceTestBase compares headers between HEAD and GET requests in testGet. It has a list of headers to ignore, which makes a lot of sense. However, it's currently missing the 'Transfer-Encoding' header which could be present on GET requests, depending on web server configuration, but obviously doesn't make much sense on a HEAD request. So it means running tests can fail, depending on web server configuration, so would be good to remove that fail factor.

Tentatively marked as bug report. It's kind of between that and task for me.

Proposed resolution

Add 'Transfer-Encoding' to the list of ignored headers in

EntityResourceTestBase::testGet()

.

Remaining tasks

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

damiankloip created an issue. See original summary.

damiankloip’s picture

Status: Active » Needs review
FileSize
1.21 KB
Wim Leers’s picture

Component: base system » rest.module
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

Totally makes sense! Thanks :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2838954-2.patch, failed testing.

Wim Leers’s picture

Status: Needs work » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 6b7acf7 to 8.3.x and 5a4db56 to 8.2.x. Thanks!

Committed this to 8.2.x as well because it is a test only change that introduces stability into our tests.

  • alexpott committed 6b7acf7 on 8.3.x
    Issue #2838954 by damiankloip: Ignore 'Transfer-Encoding' header in...

  • alexpott committed 5a4db56 on 8.2.x
    Issue #2838954 by damiankloip: Ignore 'Transfer-Encoding' header in...
damiankloip’s picture

Issue summary: View changes

Nice. Thanks, Alex!

Wim Leers’s picture

Awesome, thanks Alex :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.