Problem/Motivation
EntityResourceTestBase
compares headers between HEAD and GET requests in testGet
. It has a list of headers to ignore, which makes a lot of sense. However, it's currently missing the 'Transfer-Encoding' header which could be present on GET requests, depending on web server configuration, but obviously doesn't make much sense on a HEAD request. So it means running tests can fail, depending on web server configuration, so would be good to remove that fail factor.
Tentatively marked as bug report. It's kind of between that and task for me.
Proposed resolution
Add 'Transfer-Encoding' to the list of ignored headers in
EntityResourceTestBase::testGet()
.
Remaining tasks
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Comment | File | Size | Author |
---|---|---|---|
#2 | 2838954-2.patch | 1.21 KB | damiankloip |
Comments
Comment #2
damiankloip CreditAttribution: damiankloip at Acquia commentedComment #3
Wim LeersTotally makes sense! Thanks :)
Comment #5
Wim LeersComment #6
alexpottCommitted and pushed 6b7acf7 to 8.3.x and 5a4db56 to 8.2.x. Thanks!
Committed this to 8.2.x as well because it is a test only change that introduces stability into our tests.
Comment #9
damiankloip CreditAttribution: damiankloip at Acquia commentedNice. Thanks, Alex!
Comment #10
Wim LeersAwesome, thanks Alex :)